Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1333813003: Restrict visibility of internal TextCheckingParagraph predicates. (Closed)

Created:
5 years, 3 months ago by sof
Modified:
5 years, 3 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Restrict visibility of internal TextCheckingParagraph predicates. Reduce exposed interface slightly; no change in functionality. R= BUG=None Committed: https://crrev.com/0606d4d04b9ffe1a9d5e47a387e0fe5ea5f83376 git-svn-id: svn://svn.chromium.org/blink/trunk@202050 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M Source/core/editing/spellcheck/SpellChecker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/spellcheck/TextCheckingHelper.h View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
sof
please take a look.
5 years, 3 months ago (2015-09-10 08:18:35 UTC) #2
yosin_UTC9
lgtm Thanks for clean up! (^_^)b
5 years, 3 months ago (2015-09-10 09:12:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1333813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1333813003/1
5 years, 3 months ago (2015-09-10 09:13:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/105220)
5 years, 3 months ago (2015-09-10 10:35:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1333813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1333813003/1
5 years, 3 months ago (2015-09-10 10:51:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202050
5 years, 3 months ago (2015-09-10 13:06:14 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:10:07 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0606d4d04b9ffe1a9d5e47a387e0fe5ea5f83376

Powered by Google App Engine
This is Rietveld 408576698