Support for depth renderbuffer attachment.

Support for depth renderbuffer attachment.

Allow a depth buffer surface configuration.
Fixes the spinning cube.

R=jamesr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/00e972fb49b2f3e75a4362a68b18dc235f37eda4

[cdotstout, 2015-09-09 23:41:05]

cstout@chromium.org changed reviewers:
+ jamesr@chromium.org

[cdotstout, 2015-09-09 23:41:06]

Are there unit tests for gl_surface? I didn't spot any.

[jamesr, 2015-09-10 00:38:21]

I don't think we have any currently running unit tests for this code (there were
unit tests in chromium for //ui/gl, but they covered lots of things we won't use
and depended on frameworks and other libraries we don't really need so they got
nuked at some point.  i don't know if the unit tests in chromium covered
gl_surface_XXX or not)

lgtm

https://codereview.chromium.org/1333693004/diff/1/ui/gl/gl_surface_ozone.cc
File ui/gl/gl_surface_ozone.cc (right):

https://codereview.chromium.org/1333693004/diff/1/ui/gl/gl_surface_ozone.cc#n...
ui/gl/gl_surface_ozone.cc:583: delete rb_depth_;
you called operator new[] so you can't call operator delete to free it, that's
undefined behavior. put this in a scoped_ptr<> or std::unique_ptr<> - they have
specializations for XXX_ptr<T[]> that invoke the correct delete[] operator

https://codereview.chromium.org/1333693004/diff/1/ui/gl/gl_surface_ozone.cc#n...
ui/gl/gl_surface_ozone.cc:584: rb_depth_ = nullptr;
a real smart pointer will handle this for you too

[cdotstout, 2015-09-10 18:19:47]

https://codereview.chromium.org/1333693004/diff/1/ui/gl/gl_surface_ozone.cc
File ui/gl/gl_surface_ozone.cc (right):

https://codereview.chromium.org/1333693004/diff/1/ui/gl/gl_surface_ozone.cc#n...
ui/gl/gl_surface_ozone.cc:583: delete rb_depth_;
On 2015/09/10 00:38:21, jamesr wrote:
> you called operator new[] so you can't call operator delete to free it, that's
> undefined behavior. put this in a scoped_ptr<> or std::unique_ptr<> - they
have
> specializations for XXX_ptr<T[]> that invoke the correct delete[] operator

Done.

https://codereview.chromium.org/1333693004/diff/1/ui/gl/gl_surface_ozone.cc#n...
ui/gl/gl_surface_ozone.cc:584: rb_depth_ = nullptr;
On 2015/09/10 00:38:21, jamesr wrote:
> a real smart pointer will handle this for you too

Done.

[jamesr, 2015-09-10 18:22:27]

Thanks, looks even better!

https://codereview.chromium.org/1333693004/diff/20001/ui/gl/gl_surface_ozone.cc
File ui/gl/gl_surface_ozone.cc (right):

https://codereview.chromium.org/1333693004/diff/20001/ui/gl/gl_surface_ozone....
ui/gl/gl_surface_ozone.cc:466: std::unique_ptr<GLuint[]> rb_depth_;
add #include <memory> for this

[cdotstout, 2015-09-10 18:22:39]

Committed patchset #2 (id:20001) manually as
00e972fb49b2f3e75a4362a68b18dc235f37eda4 (presubmit successful).