Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3835)

Unified Diff: build/toolchain/nacl/BUILD.gn

Issue 1333673002: Build PPAPI NaCl Glibc tests with GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review feedback addressed Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/toolchain/nacl/BUILD.gn
diff --git a/build/toolchain/nacl/BUILD.gn b/build/toolchain/nacl/BUILD.gn
index 5bda55280fff87351c51ae922dc50a88babe5bea..90df3da99da1a8495a36ed23cf7aea193e807966 100644
--- a/build/toolchain/nacl/BUILD.gn
+++ b/build/toolchain/nacl/BUILD.gn
@@ -34,6 +34,7 @@ nacl_toolchain("newlib_arm") {
toolchain_cpu = "arm"
toolprefix = "${os_toolchain_dir}/${toolchain_package}/bin/arm-nacl-"
is_clang = false
+ is_nacl_glibc = false
cc = toolprefix + "gcc"
cxx = toolprefix + "g++"
@@ -47,6 +48,7 @@ nacl_toolchain("newlib_x86") {
toolchain_cpu = "x86"
toolprefix = "${os_toolchain_dir}/${toolchain_package}/bin/i686-nacl-"
is_clang = false
+ is_nacl_glibc = false
cc = toolprefix + "gcc"
cxx = toolprefix + "g++"
@@ -60,6 +62,7 @@ nacl_toolchain("newlib_x64") {
toolchain_cpu = "x64"
toolprefix = "${os_toolchain_dir}/${toolchain_package}/bin/x86_64-nacl-"
is_clang = false
+ is_nacl_glibc = false
cc = toolprefix + "gcc"
cxx = toolprefix + "g++"
@@ -72,6 +75,7 @@ nacl_toolchain("newlib_pnacl") {
toolchain_revision = pnacl_newlib_rev
toolchain_cpu = "pnacl"
toolprefix = "${os_toolchain_dir}/${toolchain_package}/bin/pnacl-"
+ is_nacl_glibc = false
cc = toolprefix + "clang"
cxx = toolprefix + "clang++"
@@ -93,6 +97,7 @@ nacl_toolchain("glibc_x86") {
toolchain_cpu = "x86"
toolprefix = "${os_toolchain_dir}/${toolchain_package}/bin/i686-nacl-"
is_clang = false
+ is_nacl_glibc = true
cc = toolprefix + "gcc"
cxx = toolprefix + "g++"
@@ -106,6 +111,7 @@ nacl_toolchain("glibc_x64") {
toolchain_cpu = "x64"
toolprefix = "${os_toolchain_dir}/${toolchain_package}/bin/x86_64-nacl-"
is_clang = false
+ is_nacl_glibc = true
cc = toolprefix + "gcc"
cxx = toolprefix + "g++"
@@ -119,6 +125,7 @@ nacl_toolchain("clang_newlib_x86") {
toolchain_cpu = "x86"
toolprefix = "${os_toolchain_dir}/${toolchain_package}/bin/i686-nacl-"
is_clang = true
+ is_nacl_glibc = false
cc = toolprefix + "clang"
cxx = toolprefix + "clang++"
@@ -132,6 +139,7 @@ nacl_toolchain("clang_newlib_x64") {
toolchain_cpu = "x64"
toolprefix = "${os_toolchain_dir}/${toolchain_package}/bin/x86_64-nacl-"
is_clang = true
+ is_nacl_glibc = false
cc = toolprefix + "clang"
cxx = toolprefix + "clang++"
@@ -147,6 +155,7 @@ nacl_toolchain("irt_x86") {
toolchain_cpu = "x86"
toolprefix = "${os_toolchain_dir}/${toolchain_package}/bin/i686-nacl-"
is_clang = true
+ is_nacl_glibc = false
cc = toolprefix + "clang"
cxx = toolprefix + "clang++"
@@ -175,6 +184,7 @@ nacl_toolchain("irt_x64") {
toolchain_cpu = "x64"
toolprefix = "${os_toolchain_dir}/${toolchain_package}/bin/x86_64-nacl-"
is_clang = true
+ is_nacl_glibc = false
cc = toolprefix + "clang"
cxx = toolprefix + "clang++"
@@ -198,6 +208,7 @@ nacl_toolchain("irt_arm") {
toolchain_cpu = "arm"
toolprefix = "${os_toolchain_dir}/${toolchain_package}/bin/arm-nacl-"
is_clang = false
+ is_nacl_glibc = false
cc = toolprefix + "gcc"
cxx = toolprefix + "g++"

Powered by Google App Engine
This is Rietveld 408576698