build/config/nacl/nacl.gni - Issue 1333673002: Build PPAPI NaCl Glibc tests with GN

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/config/nacl/nacl.gni

Issue 1333673002: Build PPAPI NaCl Glibc tests with GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2015 The Native Client Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 nacl_toolchain_dir = rebase_path("//native_client/toolchain")
	brettw 2015/09/09 20:52:30 I prefer keeping all variables in GN-style and the I prefer keeping all variables in GN-style and then having the users rebase as needed. This gives a bit more flexibility since future users may want this directory relative to different places. So I would keep this as: nacl_toolchain_dir = "//native_client/toolchain" in the toolchain file where you need the absolute path frequently, maybe make a new "abs_nacl_toolchain" var, and in the ppapi file when you compute glibc_toolchain_dir, just put the rebase path in there. Petr Hosek 2015/09/09 22:14:49 Done. Show quoted text On 2015/09/09 20:52:30, brettw wrote: > I prefer keeping all variables in GN-style and then having the users rebase as > needed. This gives a bit more flexibility since future users may want this > directory relative to different places. > > So I would keep this as: > nacl_toolchain_dir = "//native_client/toolchain" > in the toolchain file where you need the absolute path frequently, maybe make a > new "abs_nacl_toolchain" var, and in the ppapi file when you compute > glibc_toolchain_dir, just put the rebase path in there. Done.
	6 os_toolchain_dir = "${nacl_toolchain_dir}/${host_os}_x86"

OLD	NEW

« no previous file with comments | « no previous file | build/toolchain/nacl/BUILD.gn » ('j') | ppapi/BUILD.gn » ('J')