Issue 133363005: MIPS: Fix test-assembler-mips/MIPS10 test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 133363005: MIPS: Fix test-assembler-mips/MIPS10 test. (Closed)

Created:
6 years, 10 months ago by kilvadyb

Modified:
6 years, 10 months ago

Reviewers:
Paul Lind, palfia, Jakob Kummerow, danno, dusmil

CC:
v8-dev

Base URL:
https://github.com/v8/v8.git@gbl

Visibility:
Public.

More Reviews

Description

MIPS: Fix test-assembler-mips/MIPS10 test. cvt_l_d() and cvt_d_l() instructions are replaced to cvt_w_d() and ctv_d_w() because kernel FPU emulator generates illegal instruction for double <-> long conversions. BUG=

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -22 lines)			Patch
	M	test/cctest/test-assembler-mips.cc	View		3 chunks	+14 lines, -22 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paul Lind

LGTM. Jakob, can you PTAL? (I can't approve this MIPS-specific cctest change.)

6 years, 10 months ago (2014-02-03 18:58:40 UTC) #1

Committed as r19073.

Expand Messages | Collapse Messages