content/common/gpu/client/gl_helper_benchmark.cc - Issue 133363004: content_gl_tests should skip RGB565 test if the prior detection of format support fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/gl_helper_benchmark.cc

Issue 133363004: content_gl_tests should skip RGB565 test if the prior detection of format support fails. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Initialize variables before operating getintegerv Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/gpu/client/gl_helper_benchmark.cc

diff --git a/content/common/gpu/client/gl_helper_benchmark.cc b/content/common/gpu/client/gl_helper_benchmark.cc

index 5e098f921e0d48c512b1e6437b92c7712987215b..06b420625aefa5c4be0215d0d465c545d1d7f28f 100644

--- a/content/common/gpu/client/gl_helper_benchmark.cc

+++ b/content/common/gpu/client/gl_helper_benchmark.cc

@@ -292,7 +292,8 @@ TEST_F(GLHelperTest, DISABLED_ScaleTestImage) {

gfx::Rect(0, 0,

dst_size.width(),

dst_size.height()),

- static_cast<unsigned char *>(output_pixels.getPixels()));

+ static_cast<unsigned char *>(output_pixels.getPixels()),

+ SkBitmap::kARGB_8888_Config);

context_->deleteTexture(dst_texture);

std::string filename = base::StringPrintf("testoutput_%s_%d.ppm",

kQualityNames[q],

« no previous file with comments | « content/common/gpu/client/gl_helper.cc ('k') | content/common/gpu/client/gl_helper_unittest.cc » ('j') | no next file with comments »