Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1333583003: Initialize PartitionAlloc before creating CSSParserTokens in CSSTokenizerTest (Closed)

Created:
5 years, 3 months ago by bashi
Modified:
5 years, 3 months ago
Reviewers:
haraken, tasak
CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Initialize PartitionAlloc before creating CSSParserTokens in CSSTokenizerTest Because CSSParserTokens depends on PartitionAlloc. BUG=501171 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201956

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -76 lines) Patch
M Source/core/css/parser/CSSTokenizerTest.cpp View 1 13 chunks +88 lines, -76 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
bashi
PTAL?
5 years, 3 months ago (2015-09-09 05:46:23 UTC) #3
haraken
LGTM if this is the only place we need this kind of hack. https://codereview.chromium.org/1333583003/diff/20001/Source/core/css/parser/CSSTokenizerTest.cpp File ...
5 years, 3 months ago (2015-09-09 05:52:07 UTC) #4
bashi
Thanks! I think this is the only place for webkit_unit_tests. https://codereview.chromium.org/1333583003/diff/20001/Source/core/css/parser/CSSTokenizerTest.cpp File Source/core/css/parser/CSSTokenizerTest.cpp (right): https://codereview.chromium.org/1333583003/diff/20001/Source/core/css/parser/CSSTokenizerTest.cpp#newcode122 ...
5 years, 3 months ago (2015-09-09 05:59:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1333583003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1333583003/40001
5 years, 3 months ago (2015-09-09 05:59:26 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 06:56:49 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201956

Powered by Google App Engine
This is Rietveld 408576698