Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 1333583002: Introduce composed tree version of isEndOfEditableOrNonEditableContent() (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce composed tree version of isEndOfEditableOrNonEditableContent() This patch introduces composed tree version of |isEndOfEditableOrNonEditableContent()| by templatizing original |isEndOfEditableOrNonEditableContent()| to work both DOM tree position and composed tree position version for introducing composed tree version of |VisibleSelection| class. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201955

Patch Set 1 : 2015-09-09T13:37:29 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -2 lines) Patch
M Source/core/editing/VisibleUnits.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 1 chunk +12 lines, -1 line 0 comments Download
M Source/core/editing/VisibleUnitsTest.cpp View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-09-09 05:13:36 UTC) #2
yoichio
lgtm
5 years, 3 months ago (2015-09-09 05:20:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1333583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1333583002/1
5 years, 3 months ago (2015-09-09 05:25:37 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 06:44:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201955

Powered by Google App Engine
This is Rietveld 408576698