Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1333553002: GM: replace boilerplate with macros (Closed)

Created:
5 years, 3 months ago by hal.canary
Modified:
5 years, 3 months ago
Reviewers:
herb_g
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GM: replace boilerplate with macros I have verified locally that nothing draws differently. Motivation: * SK_SIMPLE_GM makes it easier to write a GM. * Reducing 1100 lines of code makes maintenance easier. * Simple GMs are easy to convert to Fiddles. Committed: https://skia.googlesource.com/skia/+/2a24338c777462e04a2b26295f9c034155ee8f3e

Patch Set 1 : 2015-09-08 (Tuesday) 18:21:25 EDT #

Patch Set 2 : 2015-09-09 (Wednesday) 11:01:10 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -1326 lines) Patch
M gm/astcbitmap.cpp View 2 chunks +6 lines, -33 lines 0 comments Download
M gm/beziereffects.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M gm/bigmatrix.cpp View 2 chunks +2 lines, -29 lines 0 comments Download
M gm/bigrrectaaeffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bitmaprecttest.cpp View 2 chunks +1 line, -28 lines 0 comments Download
M gm/blurrect.cpp View 2 chunks +5 lines, -194 lines 0 comments Download
M gm/blurs.cpp View 5 chunks +6 lines, -51 lines 0 comments Download
M gm/clipdrawdraw.cpp View 4 chunks +4 lines, -23 lines 0 comments Download
M gm/colorfilterimagefilter.cpp View 2 chunks +7 lines, -26 lines 0 comments Download
M gm/constcolorprocessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/convexpolyeffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/dashcubics.cpp View 3 chunks +5 lines, -28 lines 0 comments Download
M gm/dcshader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/fatpathfill.cpp View 2 chunks +4 lines, -24 lines 0 comments Download
M gm/getpostextpath.cpp View 2 chunks +4 lines, -23 lines 0 comments Download
M gm/glyph_pos.cpp View 5 chunks +39 lines, -79 lines 0 comments Download
M gm/glyph_pos_align.cpp View 1 3 chunks +4 lines, -30 lines 0 comments Download
M gm/gm.h View 1 3 chunks +25 lines, -9 lines 0 comments Download
M gm/gm.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/gradient_matrix.cpp View 2 chunks +2 lines, -26 lines 0 comments Download
M gm/hittestpath.cpp View 2 chunks +2 lines, -23 lines 0 comments Download
M gm/imageblur.cpp View 2 chunks +7 lines, -39 lines 0 comments Download
M gm/imagefilters.cpp View 3 chunks +6 lines, -20 lines 0 comments Download
M gm/imagefromyuvtextures.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/imagemagnifier.cpp View 2 chunks +1 line, -30 lines 0 comments Download
M gm/imageresizetiled.cpp View 2 chunks +1 line, -28 lines 0 comments Download
M gm/inversepaths.cpp View 4 chunks +3 lines, -26 lines 0 comments Download
M gm/largeglyphblur.cpp View 2 chunks +1 line, -27 lines 0 comments Download
M gm/lerpmode.cpp View 1 chunk +2 lines, -23 lines 0 comments Download
M gm/linepaths.cpp View 5 chunks +23 lines, -179 lines 0 comments Download
M gm/matriximagefilter.cpp View 1 4 chunks +6 lines, -35 lines 0 comments Download
M gm/mipmap.cpp View 2 chunks +1 line, -19 lines 0 comments Download
M gm/patch.cpp View 1 2 chunks +1 line, -29 lines 0 comments Download
M gm/pathreverse.cpp View 1 2 chunks +2 lines, -30 lines 0 comments Download
M gm/rrects.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/shadertext2.cpp View 3 chunks +2 lines, -27 lines 0 comments Download
M gm/skbug1719.cpp View 1 3 chunks +2 lines, -33 lines 0 comments Download
M gm/smallarc.cpp View 2 chunks +1 line, -27 lines 0 comments Download
M gm/strokefill.cpp View 1 4 chunks +9 lines, -35 lines 0 comments Download
M gm/stroketext.cpp View 2 chunks +4 lines, -24 lines 0 comments Download
M gm/texdata.cpp View 2 chunks +2 lines, -31 lines 0 comments Download
M gm/textblobrandomfont.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/textblobuseaftergpufree.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/texteffects.cpp View 2 chunks +2 lines, -24 lines 0 comments Download
M gm/texturedomaineffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/yuvtorgbeffect.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1333553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1333553002/20001
5 years, 3 months ago (2015-09-08 21:41:11 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/3132)
5 years, 3 months ago (2015-09-08 21:43:21 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1333553002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1333553002/40001
5 years, 3 months ago (2015-09-08 22:02:51 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-08 22:07:44 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1333553002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1333553002/60001
5 years, 3 months ago (2015-09-08 22:28:21 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-08 22:33:21 UTC) #15
hal.canary
PTAL
5 years, 3 months ago (2015-09-09 15:02:32 UTC) #17
herb_g
lgtm
5 years, 3 months ago (2015-09-09 15:10:56 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1333553002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1333553002/80001
5 years, 3 months ago (2015-09-09 15:11:27 UTC) #20
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 15:16:45 UTC) #21
Message was sent while issue was closed. 
Committed patchset #2 (id:80001) as
https://skia.googlesource.com/skia/+/2a24338c777462e04a2b26295f9c034155ee8f3e

Powered by Google App Engine
This is Rietveld 408576698