Issue 133353004: Fixed DTMF test on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 133353004: Fixed DTMF test on Android. (Closed)

Created:
6 years, 11 months ago by phoglund_chromium

Modified:
6 years, 11 months ago

Reviewers:
wjia(left Chromium)

CC:
chromium-reviews, craigdh+watch_chromium.org, jam, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, darin-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixed DTMF test on Android. Turns out we accidently removed the DTMF payload type from the SDP. We now preserve it even if we force iSAC. BUG=332016 R=wjia@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244200

Patch Set 1 #

Patch Set 2 : Now calling the test the right way as well #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -13 lines)			Patch
M	build/android/pylib/gtest/filter/content_browsertests_disabled	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/media/webrtc_browsertest.cc	View	1	1 chunk	+1 line, -8 lines	0 comments	Download
M	content/test/data/media/peerconnection-call.html	View		1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/133353004/40001

6 years, 11 months ago (2014-01-10 15:29:44 UTC) #3

Message was sent while issue was closed.

Change committed as 244200

Expand Messages | Collapse Messages