Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Unified Diff: test/cctest/test-date.cc

Issue 1333463002: Start removing deprecated APIs from cctest (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/cctest.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-date.cc
diff --git a/test/cctest/test-date.cc b/test/cctest/test-date.cc
index 2bcc625a95cc9c39c74b6971e0a3180c7c911ab9..89372c07eefa925696385ea63d6d550404395a41 100644
--- a/test/cctest/test-date.cc
+++ b/test/cctest/test-date.cc
@@ -25,6 +25,9 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+// TODO(jochen): Remove this after the setting is turned on globally.
+#define V8_IMMINENT_DEPRECATION_WARNINGS
+
#include "src/v8.h"
#include "src/global-handles.h"
@@ -173,18 +176,24 @@ TEST(DateCacheVersion) {
v8::Isolate* isolate = CcTest::isolate();
v8::Isolate::Scope isolate_scope(isolate);
v8::HandleScope scope(isolate);
- v8::Handle<v8::Context> context = v8::Context::New(isolate);
+ v8::Local<v8::Context> context = v8::Context::New(isolate);
v8::Context::Scope context_scope(context);
- v8::Handle<v8::Array> date_cache_version =
- v8::Handle<v8::Array>::Cast(CompileRun("%DateCacheVersion()"));
+ v8::Local<v8::Array> date_cache_version =
+ v8::Local<v8::Array>::Cast(CompileRun("%DateCacheVersion()"));
CHECK_EQ(1, static_cast<int32_t>(date_cache_version->Length()));
- CHECK(date_cache_version->Get(0)->IsNumber());
- CHECK_EQ(0.0, date_cache_version->Get(0)->NumberValue());
+ CHECK(date_cache_version->Get(context, 0).ToLocalChecked()->IsNumber());
+ CHECK_EQ(0.0, date_cache_version->Get(context, 0)
+ .ToLocalChecked()
+ ->NumberValue(context)
+ .FromJust());
v8::Date::DateTimeConfigurationChangeNotification(isolate);
CHECK_EQ(1, static_cast<int32_t>(date_cache_version->Length()));
- CHECK(date_cache_version->Get(0)->IsNumber());
- CHECK_EQ(1.0, date_cache_version->Get(0)->NumberValue());
+ CHECK(date_cache_version->Get(context, 0).ToLocalChecked()->IsNumber());
+ CHECK_EQ(1.0, date_cache_version->Get(context, 0)
+ .ToLocalChecked()
+ ->NumberValue(context)
+ .FromJust());
}
« no previous file with comments | « test/cctest/cctest.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698