Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1333463002: Start removing deprecated APIs from cctest (Closed)

Created:
5 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 3 months ago
Reviewers:
rmcilroy, vogelheim
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Start removing deprecated APIs from cctest BUG=4134 R=vogelheim@chromium.org,rmcilroy@chromium.org LOG=n Committed: https://crrev.com/c161799f2cfb3229d38adf7e98475add68cc94fc Cr-Commit-Position: refs/heads/master@{#30622}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -40 lines) Patch
M test/cctest/cctest.h View 1 9 chunks +71 lines, -33 lines 0 comments Download
M test/cctest/test-date.cc View 2 chunks +16 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jochen (gone - plz use gerrit)
5 years, 3 months ago (2015-09-07 13:06:37 UTC) #1
jochen (gone - plz use gerrit)
ptal
5 years, 3 months ago (2015-09-07 13:51:32 UTC) #2
rmcilroy
lgtm with an optional suggestion. Thanks! https://codereview.chromium.org/1333463002/diff/1/test/cctest/cctest.h File test/cctest/cctest.h (right): https://codereview.chromium.org/1333463002/diff/1/test/cctest/cctest.h#newcode452 test/cctest/cctest.h:452: return v8::Local<v8::Value>(); nit ...
5 years, 3 months ago (2015-09-07 14:01:44 UTC) #3
vogelheim
lgtm
5 years, 3 months ago (2015-09-07 14:03:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1333463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1333463002/20001
5 years, 3 months ago (2015-09-07 14:21:08 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-07 14:44:52 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-07 14:45:05 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c161799f2cfb3229d38adf7e98475add68cc94fc
Cr-Commit-Position: refs/heads/master@{#30622}

Powered by Google App Engine
This is Rietveld 408576698