Added "Use an autoconfiguration URL" checkbox in proxy tab

chrome/browser/chromeos/proxy_cros_settings_parser.cc

Index: chrome/browser/chromeos/proxy_cros_settings_parser.cc
diff --git a/chrome/browser/chromeos/proxy_cros_settings_parser.cc b/chrome/browser/chromeos/proxy_cros_settings_parser.cc
index e902a5e0738f0bc3882ca7adc816b8ead8f9bde1..9a5e43031b3ef7049063b2057c1dddaf585dc080 100644
--- a/chrome/browser/chromeos/proxy_cros_settings_parser.cc
+++ b/chrome/browser/chromeos/proxy_cros_settings_parser.cc
@@ -29,6 +29,7 @@ const char kProxyFtpPort[]        = "cros.session.proxy.ftpport";
 const char kProxySocks[]          = "cros.session.proxy.socks";
 const char kProxySocksPort[]      = "cros.session.proxy.socksport";
 const char kProxyIgnoreList[]     = "cros.session.proxy.ignorelist";
+const char kProxyUsePacUrl[]      = "cros.session.proxy.usepacurl";

[pneubeck (no reviews), 2013/04/09 09:48:19]

I don't like this forwarding of every UI element's value to C++ but rather keep
as many details locally in JS as possible.

What you have in the UI is a two level nesting of conditionals:
  'type (direct/manual/auto)'
  if 'type == auto' -> 'use pac URL'
  if 'use pac URL' -> 'pac URL'

but in C++ there is only one conditional: 'type (direct/manual/PAC/WPAD)'.

I'd very much prefer, if you did the mapping in JS and not in C++.
This would in particular allow to verify the URL (at least check for the input
field to be non-empty) at first within JS before sending pref changes to C++.

[sathish.kuppuswamy, 2013/04/16 16:46:57]

Hi pneubeck,
   Here(.js) you want me to check the URL field is empty or not, when usePacUrl
checkbox is checked and send a preference commit call to save the same to
backend with this call
Preferences.setURLPref(pref,Value,true);  ?
 I didn't dig deep into working of preferences. I just made sure this works
similar to other checkbox(use same proxy) in proxy tab .
  

 
 const char* const kProxySettings[] = {
   kProxyPacUrl,
@@ -45,6 +46,7 @@ const char* const kProxySettings[] = {
   kProxySocks,
   kProxySocksPort,
   kProxyIgnoreList,
+  kProxyUsePacUrl

[Dan Beam, 2013/04/06 01:45:14]

nit: ,

 };
 
 // We have to explicitly export this because the arraysize macro doesn't like
@@ -232,6 +234,16 @@ void SetProxyPrefValue(Profile* profile,
         config_service->UISetProxyConfigToProxyPerScheme("http",
             config.http_proxy.server);
     }
+  } else if (path == kProxyUsePacUrl) {
+    bool use_pac_url;
+    if (in_value->GetAsBoolean(&use_pac_url)) {
+      if (use_pac_url && config.automatic_proxy.pac_url.is_valid()) {
+        config_service->UISetProxyConfigToPACScript(
+               config.automatic_proxy.pac_url);
+      } else {
+        config_service->UISetProxyConfigToAutoDetect();
+      }
+    }
   } else if (path == kProxyFtpUrl) {
     std::string val;
     if (in_value->GetAsString(&val)) {
@@ -337,6 +349,9 @@ bool GetProxyPrefValue(Profile* profile,
   } else if (path == kProxySingle) {
     data = base::Value::CreateBooleanValue(config.mode ==
         chromeos::ProxyConfigServiceImpl::ProxyConfig::MODE_SINGLE_PROXY);
+  } else if (path == kProxyUsePacUrl) {
+     data = base::Value::CreateBooleanValue(config.mode ==
+          chromeos::ProxyConfigServiceImpl::ProxyConfig::MODE_PAC_SCRIPT);
   } else if (path == kProxyFtpUrl) {
     data = CreateServerHostValue(config.ftp_proxy);
   } else if (path == kProxySocks) {