Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1333353005: [turbofan] Limit the load/store machine types to the ones we actually use. (Closed)

Created:
5 years, 3 months ago by Jarin
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Limit the load/store machine types to the ones we actually use. Committed: https://crrev.com/a86db19e0a6ec9d428834813b138df67ba351edb Cr-Commit-Position: refs/heads/master@{#30725}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -107 lines) Patch
M src/compiler/machine-operator.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/machine-operator.cc View 6 chunks +11 lines, -26 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 5 chunks +4 lines, -67 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/unittests/compiler/machine-operator-unittest.cc View 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jarin
Could you take a look, please? (I tried to rewrite the representation change test not ...
5 years, 3 months ago (2015-09-14 14:03:18 UTC) #2
Benedikt Meurer
LGTM (I'm perfectly fine with removing some of the weird tests there, because for some ...
5 years, 3 months ago (2015-09-15 04:37:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1333353005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1333353005/1
5 years, 3 months ago (2015-09-15 05:44:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 05:45:25 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 05:45:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a86db19e0a6ec9d428834813b138df67ba351edb
Cr-Commit-Position: refs/heads/master@{#30725}

Powered by Google App Engine
This is Rietveld 408576698