Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(18)

Issue 1333323003: SnapManager implementation using V8 Extras - {WIP}

Created:
2 years, 2 months ago by majidvp
Modified:
1 year, 4 months ago
Reviewers:
CC:
domenic
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Scroll snap manager implemented on main-thread and integrated using V8 Extras Use with following flags: --disable-threaded-scrolling --enable-blink-features=CSSScrollSnapPoints,ScrollCustomization Requires main-thread scroll customization: https://crrev.com/1236913004/ Requires the following snippet patched in chromium: --- a/build/common.gypi +++ b/build/common.gypi @@ -1520,6 +1520,12 @@ # Compile d8 for the host toolset. 'v8_toolset_for_d8': 'host', + # Add the streams V8 extension to the snapshot + 'v8_extra_library_files': [ + '../third_party/WebKit/Source/core/page/scrolling/snap/SnapManager.js', + ], + CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Patch Set 1 #

Patch Set 2 : Migrate post repo merge #

Patch Set 3 : updater #

Patch Set 4 : Update with latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+768 lines, -14 lines) Patch
M build/common.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M build_overrides/v8.gni View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/core_generated.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 3 3 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/SnapCoordinator.h View 1 2 3 3 chunks +21 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/SnapCoordinator.cpp View 1 2 3 3 chunks +32 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/core/page/scrolling/snap/SnapManager.idl View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/Source/core/page/scrolling/snap/SnapManager.js View 1 2 3 1 chunk +486 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/page/scrolling/snap/SnapManagerBridge.h View 1 2 3 1 chunk +54 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/page/scrolling/snap/SnapManagerBridge.cpp View 1 2 3 1 chunk +60 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/blink_resources.grd View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/benchmarks/memory.py View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/smoothness.py View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
A tools/perf/page_sets/snappoints_cases.py View 1 1 chunk +26 lines, -0 lines 0 comments Download
A tools/perf/page_sets/snappoints_cases/1000_snap_elements.html View 1 1 chunk +44 lines, -0 lines 0 comments Download
Trybot results:

Messages

Total messages: 3 (0 generated)
majidvp
2 years, 2 months ago (2015-09-11 20:08:48 UTC) #1
majidvp
On 2015/09/11 20:08:48, majidvp wrote: domenic@: this is my initial snappoints integration using V8 Extras. ...
2 years, 2 months ago (2015-09-11 20:13:01 UTC) #2
majidvp
2 years, 2 months ago (2015-09-11 20:13:14 UTC) #3

          

Powered by Google App Engine
This is Rietveld efc10ee0f