chrome/browser/download/notification/download_item_notification.cc - Issue 1333323002: Add UMA metrics for the frequency of closing dangerous download notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/notification/download_item_notification.cc

Issue 1333323002: Add UMA metrics for the frequency of closing dangerous download notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Keeping changes of metrics for recording action only. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/download/notification/download_item_notification.cc

diff --git a/chrome/browser/download/notification/download_item_notification.cc b/chrome/browser/download/notification/download_item_notification.cc

index 540bcafef4c5b0e5a202eadc7958e1e6d1767c12..05caef817c6f436eacfb3fdda5ec6d23e79f38b1 100644

--- a/chrome/browser/download/notification/download_item_notification.cc

+++ b/chrome/browser/download/notification/download_item_notification.cc

@@ -211,7 +211,8 @@ void DownloadItemNotification::OnNotificationClose() {

visible_ = false;

if (item_ && item_->IsDangerous() && !item_->IsDone()) {

- // TODO(yoshiki): Add metrics.

+ content::RecordAction(

+ UserMetricsAction("DownloadNotification.Close_Dangerous"));

item_->Cancel(true /* by_user */);

return;

}

« no previous file with comments | « no previous file | tools/metrics/actions/actions.xml » ('j') | no next file with comments »