bindings: Fixes exposed JS APIs for platform apps.

extensions/renderer/resources/platform_app.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var $console = window.console;

[not at google - send to devlin, 2015/09/15 20:04:45]

cleanup: we now save the console object automatically, so you can remove
$console.

[Yuki, 2015/09/16 03:21:53]

Done.

 
 /**
  * Returns a function that logs a 'not available' error to the console and
  * returns undefined.
  *
  * @param {string} messagePrefix text to prepend to the exception message.
  */
 function generateDisabledMethodStub(messagePrefix, opt_messageSuffix) {
   var message = messagePrefix + ' is not available in packaged apps.';
   if (opt_messageSuffix) message = message + ' ' + opt_messageSuffix;
@@ skipping 134 matching lines @@
 
 // Replace evil Document methods with exception-throwing stubs.
 disableMethods(HTMLDocument.prototype, 'document', ['write', 'writeln'], true);
 
 // Disable history.
 Object.defineProperty(window, "history", { value: {} });
 disableGetters(window.history, 'history',
     ['back', 'forward', 'go', 'length', 'pushState', 'replaceState']);
 
 // Disable find.
+disableMethods(window, 'window', ['find']);
 disableMethods(Window.prototype, 'window', ['find']);
 
 // Disable modal dialogs. Shell windows disable these anyway, but it's nice to
 // warn.
+disableMethods(window, 'window', ['alert', 'confirm', 'prompt']);
 disableMethods(Window.prototype, 'window', ['alert', 'confirm', 'prompt']);
 
 // Disable window.*bar.
 disableGetters(window, 'window',
     ['locationbar', 'menubar', 'personalbar', 'scrollbars', 'statusbar',
      'toolbar']);
 
 // Disable window.localStorage.
 // Sometimes DOM security policy prevents us from doing this (e.g. for data:
 // URLs) so wrap in try-catch.
@@ skipping 17 matching lines @@
   // https://developer.mozilla.org/en/DOM/document.
   // To deprecate document.all, simply changing its getter and setter would
   // activate its cache mechanism, and degrade the performance. Here we assign
   // it first to 'undefined' to avoid this.
   document.all = undefined;
   disableGetters(document, 'document',
       ['alinkColor', 'all', 'bgColor', 'fgColor', 'linkColor', 'vlinkColor']);
 }, true);
 
 // Disable onunload, onbeforeunload.
+disableSetters(window, 'window', ['onbeforeunload', 'onunload']);
 disableSetters(Window.prototype, 'window', ['onbeforeunload', 'onunload']);
-var windowAddEventListener = Window.prototype.addEventListener;
-Window.prototype.addEventListener = function(type) {
+var eventTargetAddEventListener = EventTarget.prototype.addEventListener;
+EventTarget.prototype.addEventListener = function(type) {
   if (type === 'unload' || type === 'beforeunload')
     generateDisabledMethodStub(type)();
   else
-    return $Function.apply(windowAddEventListener, window, arguments);
+    return $Function.apply(eventTargetAddEventListener, this, arguments);
 };