Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 1333303002: bindings: Fixes exposed JS APIs for platform apps. (Closed)

Created:
5 years, 3 months ago by Yuki
Modified:
5 years, 3 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, posciak+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, chromium-apps-reviews_chromium.org, cc-bugs_chromium.org, wjia+watch_chromium.org, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bindings: Fixes exposed JS APIs for platform apps. We're disabling some of DOM attributes and operations for platform apps. Since event handlers and operations in Window are going to move onto the instance object, we need to update disabling code accordingly. Also fixes a way to disable addEventListener. It's defined on EventTarget.prototype, not on Window.prototype. Also it shouldn't change |this| object. This CL is a preparation of http://crrev.com/1333853002 BUG=43394, 516274 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/37799a7c9a4dc1b06d627cc17bb989c25663ada3 Cr-Commit-Position: refs/heads/master@{#349376}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Addressed a review comment. #

Patch Set 3 : Synced. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M extensions/renderer/resources/platform_app.js View 1 4 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Yuki
Derek, could you review this CL as an owner?
5 years, 3 months ago (2015-09-11 14:20:48 UTC) #3
Yuki
+kalman, could you review this CL?
5 years, 3 months ago (2015-09-15 05:03:31 UTC) #5
not at google - send to devlin
lgtm https://codereview.chromium.org/1333303002/diff/20001/extensions/renderer/resources/platform_app.js File extensions/renderer/resources/platform_app.js (right): https://codereview.chromium.org/1333303002/diff/20001/extensions/renderer/resources/platform_app.js#newcode5 extensions/renderer/resources/platform_app.js:5: var $console = window.console; cleanup: we now save ...
5 years, 3 months ago (2015-09-15 20:04:45 UTC) #6
Yuki
https://codereview.chromium.org/1333303002/diff/20001/extensions/renderer/resources/platform_app.js File extensions/renderer/resources/platform_app.js (right): https://codereview.chromium.org/1333303002/diff/20001/extensions/renderer/resources/platform_app.js#newcode5 extensions/renderer/resources/platform_app.js:5: var $console = window.console; On 2015/09/15 20:04:45, kalman wrote: ...
5 years, 3 months ago (2015-09-16 03:21:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1333303002/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1333303002/30001
5 years, 3 months ago (2015-09-16 03:22:15 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/104559)
5 years, 3 months ago (2015-09-16 07:47:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1333303002/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1333303002/50001
5 years, 3 months ago (2015-09-17 07:13:47 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:50001)
5 years, 3 months ago (2015-09-17 08:04:47 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 08:05:27 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/37799a7c9a4dc1b06d627cc17bb989c25663ada3
Cr-Commit-Position: refs/heads/master@{#349376}

Powered by Google App Engine
This is Rietveld 408576698