Issue 13333004: [uiautomator] Add a gypi for building Android uiautomator test jars.

Issue 13333004: [uiautomator] Add a gypi for building Android uiautomator test jars. (Closed)

Created:
7 years, 8 months ago by frankf

Modified:
6 years, 10 months ago

Reviewers:
cjhopman, Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[uiautomator] Add a gypi for building Android uiautomator test jars. BUG=168922 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191723

Patch Set 2 : Fixed comment #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -22 lines)			Patch
	A +	build/uiautomator_test.gypi	View	1	2 chunks	+10 lines, -22 lines	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

cjhopman

lgtm https://codereview.chromium.org/13333004/diff/1/build/uiautomator_test.gypi File build/uiautomator_test.gypi (right): https://codereview.chromium.org/13333004/diff/1/build/uiautomator_test.gypi#newcode41 build/uiautomator_test.gypi:41: '--ignore=>!(echo >(_inputs) | md5sum)', Change: >(_inputs) to: \'>(_inputs)\' ...

7 years, 8 months ago (2013-04-01 20:35:40 UTC) #2

frankf

https://codereview.chromium.org/13333004/diff/1/build/uiautomator_test.gypi File build/uiautomator_test.gypi (right): https://codereview.chromium.org/13333004/diff/1/build/uiautomator_test.gypi#newcode41 build/uiautomator_test.gypi:41: '--ignore=>!(echo >(_inputs) | md5sum)', On 2013/04/01 20:35:40, cjhopman wrote: ...

7 years, 8 months ago (2013-04-01 20:49:27 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/frankf@chromium.org/13333004/4001

7 years, 8 months ago (2013-04-01 20:50:32 UTC) #4

frankf

Committed patchset #2 manually as r191723 (presubmit successful).

7 years, 8 months ago (2013-04-02 00:37:31 UTC) #5

Nico

6 years, 10 months ago (2014-01-30 05:19:26 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/13333004/diff/4001/build/uiautomator_test.gypi
File build/uiautomator_test.gypi (right):

https://codereview.chromium.org/13333004/diff/4001/build/uiautomator_test.gyp...
build/uiautomator_test.gypi:41: '--ignore=>!(echo \'>(_inputs)\' | md5sum)',
Since library_dexed_jars_paths is passed as parameter to dex.py, this line is
unnecessary, right?

Expand Messages | Collapse Messages