Issue 13333003: Create a new base/message_loop directory and move the message_loop_proxy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13333003: Create a new base/message_loop directory and move the message_loop_proxy. (Closed)

Created:
7 years, 8 months ago by brettw

Modified:
7 years, 8 months ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Create a new base/message_loop directory and move the message_loop_proxy. Eventually we'll move all the message loop and message pump classes into this directory. This leaves a forwarding header to avoid having to update all includes in this patch. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191422

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -632 lines)			Patch
M	base/base.gyp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	base/base.gypi	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	base/message_loop.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	base/message_loop/message_loop_proxy.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	base/message_loop/message_loop_proxy.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	base/message_loop/message_loop_proxy_impl.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	base/message_loop/message_loop_proxy_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	base/message_loop/message_loop_proxy_impl_unittest.cc	View	4 chunks	+21 lines, -18 lines	0 comments	Download
A +	base/message_loop/message_loop_proxy_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/message_loop_proxy.h	View	1 chunk	+4 lines, -35 lines	0 comments	Download
D	base/message_loop_proxy.cc	View	1 chunk	+0 lines, -17 lines	0 comments	Download
D	base/message_loop_proxy_impl.h	View	1 chunk	+0 lines, -62 lines	0 comments	Download
D	base/message_loop_proxy_impl.cc	View	1 chunk	+0 lines, -92 lines	0 comments	Download
D	base/message_loop_proxy_impl_unittest.cc	View	1 chunk	+0 lines, -126 lines	0 comments	Download
D	base/message_loop_proxy_unittest.cc	View	1 chunk	+0 lines, -266 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

7 years, 8 months ago (2013-03-29 19:22:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r191422 (presubmit successful).

Expand Messages | Collapse Messages