Issue 1333243002: solaris: fix spurious ;

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1333243002: solaris: fix spurious ; (Closed)

Created:
5 years, 3 months ago by vapier

Modified:
5 years, 3 months ago

Reviewers:
Ted Mielczarek

CC:
google-breakpad-dev_googlegroups.com

Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

solaris: fix spurious ; As reported in the issue tracker, building on Solaris 8 fails: .../src/common/solaris/guid_creator.cc:69: error: extra `;' BUG=google-breakpad:251 R=ted.mielczarek@gmail.com Committed: https://chromium.googlesource.com/breakpad/breakpad/+/cf1d2dcef904d3d118d749d6a3436ac72676c04f

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/common/solaris/guid_creator.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Ted Mielczarek

LGTM, although I'm not sure anyone cares about the Solaris code anymore.

5 years, 3 months ago (2015-09-11 10:50:48 UTC) #3

vapier

5 years, 3 months ago (2015-09-11 16:59:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
cf1d2dcef904d3d118d749d6a3436ac72676c04f (presubmit successful).