utils/pub/validator/utf8_readme.dart - Issue 13332009: Make listDir and createSymlink synchronous in pub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: utils/pub/validator/utf8_readme.dart

Issue 13332009: Make listDir and createSymlink synchronous in pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: utils/pub/validator/utf8_readme.dart

diff --git a/utils/pub/validator/utf8_readme.dart b/utils/pub/validator/utf8_readme.dart

index 145ac86115feb0a6555d335c96cd77ffb50edb87..8bf52a9d302bfa8d1781a279f7486eac3535577d 100644

--- a/utils/pub/validator/utf8_readme.dart

+++ b/utils/pub/validator/utf8_readme.dart

@@ -20,7 +20,8 @@ class Utf8ReadmeValidator extends Validator {

: super(entrypoint);

Future validate() {

- return entrypoint.root.readmePath.then((readme) {

+ return new Future.of(() {

+ var readme = entrypoint.root.readmePath;

if (readme == null) return;

var bytes = readBinaryFile(readme);

try {

« no previous file with comments | « utils/pub/validator/name.dart ('k') | utils/tests/pub/descriptor/tar.dart » ('j') | no next file with comments »