Make listDir and createSymlink synchronous in pub.

utils/pub/validator/name.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library name_validator;
 
 import 'dart:async';
 import 'dart:io';
 
 import 'package:pathos/path.dart' as path;
@@ skipping 10 matching lines @@
   "new", "null", "return", "super", "switch", "this", "throw", "true", "try",
   "var", "void", "while", "with"
 ];
 
 /// A validator that validates the name of the package and its libraries.
 class NameValidator extends Validator {
   NameValidator(Entrypoint entrypoint)
     : super(entrypoint);
 
   Future validate() {
-    _checkName(entrypoint.root.name, 'Package name "${entrypoint.root.name}"',
-        isPackage: true);
+    return new Future.of(() {
+      _checkName(entrypoint.root.name, 'Package name "${entrypoint.root.name}"',
+          isPackage: true);
 
-    return _libraries.then((libraries) {
+      var libraries = _libraries;
       for (var library in libraries) {
         var libName = path.basenameWithoutExtension(library);
         _checkName(libName, 'The name of "$library", "$libName",',
             isPackage: false);
       }
 
       if (libraries.length == 1) {
         var libName = path.basenameWithoutExtension(libraries[0]);
         if (libName == entrypoint.root.name) return;
         warnings.add('The name of "${libraries[0]}", "$libName", should match '
             'the name of the package, "${entrypoint.root.name}".\n'
             'This helps users know what library to import.');
       }
     });
   }
 
   /// Returns a list of all libraries in the current package as paths relative
   /// to the package's root directory.
-  Future<List<String>> get _libraries {
+  List<String> get _libraries {
     var libDir = path.join(entrypoint.root.dir, "lib");
-    return defer(() {
-      if (!dirExists(libDir)) return [];
-      return listDir(libDir, recursive: true);
-    }).then((files) {
-      return files
-          .map((file) => path.relative(file, from: path.dirname(libDir)))
-          .where((file) => !path.split(file).contains("src") &&
-                           path.extension(file) == '.dart')
-          .toList();
-    });
+    if (!dirExists(libDir)) return [];
+    return listDir(libDir, recursive: true)
+        .map((file) => path.relative(file, from: path.dirname(libDir)))
+        .where((file) => !path.split(file).contains("src") &&
+                         path.extension(file) == '.dart')
+        .toList();
   }
 
   void _checkName(String name, String description, {bool isPackage}) {
     // Packages names are more stringent than libraries.
     var messages = isPackage ? errors : warnings;
 
     if (name == "") {
       errors.add("$description may not be empty.");
     } else if (!new RegExp(r"^[a-zA-Z0-9_]*$").hasMatch(name)) {
       messages.add("$description may only contain letters, numbers, and "
@@ skipping 18 matching lines @@
       builder
         ..write(source.substring(lastMatchEnd, match.start + 1))
         ..write("_")
         ..write(match.group(1).toLowerCase());
       lastMatchEnd = match.end;
     }
     builder.write(source.substring(lastMatchEnd));
     return builder.toString().toLowerCase();
   }
 }