Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1333193005: [turbofan] Fix JSInliner to handle non-returning bodies. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix JSInliner to handle non-returning bodies. The assumption that every function body produces a value does not hold for functions that e.g. unconditionally throw or endlessly loop. This fixes the inlining logic to handle such cases. R=bmeurer@chromium.org TEST=mjsunit/regress/regress-crbug-530598 BUG=chromium:530598 LOG=n Committed: https://crrev.com/9e47ec6edab84adcbd180d2e7fa03fcb2d9295ee Cr-Commit-Position: refs/heads/master@{#30738}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -16 lines) Patch
M src/compiler/js-inlining.cc View 1 chunk +21 lines, -16 lines 1 comment Download
A test/mjsunit/regress/regress-crbug-530598.js View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
https://codereview.chromium.org/1333193005/diff/1/src/compiler/js-inlining.cc File src/compiler/js-inlining.cc (right): https://codereview.chromium.org/1333193005/diff/1/src/compiler/js-inlining.cc#newcode212 src/compiler/js-inlining.cc:212: ReplaceWithValue(call, call, call, jsgraph_->Dead()); Ideally this could be a ...
5 years, 3 months ago (2015-09-15 09:44:15 UTC) #1
Benedikt Meurer
LGTM.
5 years, 3 months ago (2015-09-15 11:15:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1333193005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1333193005/1
5 years, 3 months ago (2015-09-15 11:17:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 11:19:10 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 11:19:30 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e47ec6edab84adcbd180d2e7fa03fcb2d9295ee
Cr-Commit-Position: refs/heads/master@{#30738}

Powered by Google App Engine
This is Rietveld 408576698