Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1333193004: Increment style version for all style changes. (Closed)

Created:
5 years, 3 months ago by rune
Modified:
5 years, 3 months ago
Reviewers:
esprehn, Eric Willigers
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Increment style version for all style changes. markAncestorsWithChildNeedsStyleRecalc incremented styleVersion on Document, while markAncestorsWithChildNeedsStyleInvalidation did not. That made us detect style changes differently depending on the type of selectors which would be affected by a change - if we would schedule an invalidation set, or set SubtreeStyleChange directly. Instead increment style version on scheduleLayoutTreeUpdate. R=ericwilligers@chromium.org,esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202419

Patch Set 1 #

Patch Set 2 : Increment style version in scheduleLayoutTreeUpdate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M Source/core/dom/Document.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/DocumentTest.cpp View 1 chunk +29 lines, -0 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 21 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1333193004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1333193004/1
5 years, 3 months ago (2015-09-14 23:07:54 UTC) #2
rune
Change necessary to avoid a test regression in https://codereview.chromium.org/1317533002/
5 years, 3 months ago (2015-09-14 23:09:48 UTC) #3
Eric Willigers
lgtm Lots of thanks.
5 years, 3 months ago (2015-09-14 23:49:27 UTC) #4
esprehn
Hmm, adding/removing sheets will also change style and schedule recalcs but doesn't increment this. Why ...
5 years, 3 months ago (2015-09-15 00:00:55 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-15 00:37:56 UTC) #7
rune
On 2015/09/15 00:00:55, esprehn wrote: > Hmm, adding/removing sheets will also change style and schedule ...
5 years, 3 months ago (2015-09-15 14:52:17 UTC) #8
rune
On 2015/09/15 14:52:17, rune wrote: > On 2015/09/15 00:00:55, esprehn wrote: > > Hmm, adding/removing ...
5 years, 3 months ago (2015-09-16 09:18:39 UTC) #9
esprehn
On 2015/09/16 at 09:18:39, rune wrote: > On 2015/09/15 14:52:17, rune wrote: > > On ...
5 years, 3 months ago (2015-09-16 09:26:12 UTC) #10
rune
On 2015/09/16 09:26:12, esprehn wrote: > On 2015/09/16 at 09:18:39, rune wrote: > > On ...
5 years, 3 months ago (2015-09-16 10:54:27 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1333193004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1333193004/20001
5 years, 3 months ago (2015-09-16 22:55:53 UTC) #13
rune
On 2015/09/16 10:54:27, rune wrote: > On 2015/09/16 09:26:12, esprehn wrote: > > On 2015/09/16 ...
5 years, 3 months ago (2015-09-16 22:58:09 UTC) #14
esprehn
lgtm
5 years, 3 months ago (2015-09-16 23:00:03 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-17 01:17:34 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1333193004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1333193004/20001
5 years, 3 months ago (2015-09-17 02:51:55 UTC) #20
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 02:57:34 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202419

Powered by Google App Engine
This is Rietveld 408576698