Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1333173004: mandoline: Add back/forward support and UI. (Closed)

Created:
5 years, 3 months ago by Elliot Glaysher
Modified:
5 years, 3 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mandoline: Add back/forward support and UI. BUG=526268 TBR=jam@chromium.org Previous Review URL: https://codereview.chromium.org/1326443006 Committed: https://crrev.com/6e23e065a00bff7aee9d582728c05728ac3892e3 Cr-Commit-Position: refs/heads/master@{#348786}

Patch Set 1 #

Patch Set 2 : Add static cast. #

Patch Set 3 : Merge with ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+474 lines, -74 lines) Patch
A components/test/data/web_view/test_one.html View 1 chunk +1 line, -0 lines 0 comments Download
A components/test/data/web_view/test_three.html View 1 chunk +1 line, -0 lines 0 comments Download
D components/test/data/web_view/test_title_changed.html View 1 chunk +0 lines, -1 line 0 comments Download
A components/test/data/web_view/test_two.html View 1 chunk +1 line, -0 lines 0 comments Download
M components/web_view/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M components/web_view/public/interfaces/web_view.mojom View 1 2 3 chunks +10 lines, -0 lines 0 comments Download
M components/web_view/test_runner/test_runner_application_delegate.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M components/web_view/test_runner/test_runner_application_delegate.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A components/web_view/url_request_cloneable.h View 1 chunk +53 lines, -0 lines 0 comments Download
A components/web_view/url_request_cloneable.cc View 1 1 chunk +60 lines, -0 lines 0 comments Download
M components/web_view/web_view_apptest.cc View 1 2 4 chunks +95 lines, -16 lines 0 comments Download
M components/web_view/web_view_impl.h View 1 2 4 chunks +19 lines, -1 line 0 comments Download
M components/web_view/web_view_impl.cc View 1 2 4 chunks +52 lines, -2 lines 0 comments Download
M mandoline/ui/desktop_ui/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M mandoline/ui/desktop_ui/browser_commands.h View 1 chunk +2 lines, -0 lines 0 comments Download
M mandoline/ui/desktop_ui/browser_window.h View 1 2 6 chunks +9 lines, -12 lines 0 comments Download
M mandoline/ui/desktop_ui/browser_window.cc View 1 2 11 chunks +53 lines, -42 lines 0 comments Download
A mandoline/ui/desktop_ui/toolbar_view.h View 1 chunk +45 lines, -0 lines 0 comments Download
A mandoline/ui/desktop_ui/toolbar_view.cc View 1 chunk +55 lines, -0 lines 0 comments Download
M mandoline/ui/phone_ui/phone_browser_application_delegate.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M mandoline/ui/phone_ui/phone_browser_application_delegate.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Elliot Glaysher
(tbring this; i'll land as soon as I have win64 gn green tryjobs.)
5 years, 3 months ago (2015-09-14 21:10:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1333173004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1333173004/20001
5 years, 3 months ago (2015-09-14 22:32:59 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/99600)
5 years, 3 months ago (2015-09-14 22:46:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1333173004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1333173004/40001
5 years, 3 months ago (2015-09-14 22:49:44 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-15 00:26:16 UTC) #9
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/6e23e065a00bff7aee9d582728c05728ac3892e3 Cr-Commit-Position: refs/heads/master@{#348786}
5 years, 3 months ago (2015-09-15 00:26:52 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:40:04 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/6e23e065a00bff7aee9d582728c05728ac3892e3
Cr-Commit-Position: refs/heads/master@{#348786}

Powered by Google App Engine
This is Rietveld 408576698