Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1333153002: Revert of [Pywebsocket PerformanceTests 2/2] Add blink_perf.pywebsocket (Closed)

Created:
5 years, 3 months ago by Rick Byers
Modified:
5 years, 3 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Pywebsocket PerformanceTests 2/2] Add blink_perf.pywebsocket (patchset #17 id:500001 of https://codereview.chromium.org/736653002/ ) Reason for revert: New test on the reference build causing Linux and Mac perf bots to fail. http://crbug.com/530374 Original issue's description: > [Pywebsocket PerformanceTests 2/2] Add blink_perf.pywebsocket > > This CL adds blink_perf.pywebsocket, in which > - Pywebsocket server is started at localhost:8001, and > - Browser option --disable-web-security is added, > because we need cross-origin accesses between > memory_cache_http_server and pywebsocket server. > > [1/2] PerformanceTests scripts: https://codereview.chromium.org/738753002/ > [2/2] Telemetry: This CL > > BUG=432408 > > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect > > Committed: https://crrev.com/ab513a3c1d3c7a14b55f26f6978ac31ffe530e00 > Cr-Commit-Position: refs/heads/master@{#348149} TBR=sullivan@chromium.org,nednguyen@google.com,aiolos@chromium.org,cylee@google.com,nednguyen@chromium.org,hiroshige@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=432408, 530374 Committed: https://crrev.com/f0bb6fbe7b5d06f2d8b507462cf4b156d6aa34be Cr-Commit-Position: refs/heads/master@{#348289}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -89 lines) Patch
M tools/perf/benchmarks/blink_perf.py View 3 chunks +0 lines, -39 lines 0 comments Download
D tools/perf/benchmarks/pywebsocket_server.py View 1 chunk +0 lines, -40 lines 0 comments Download
M tools/telemetry/telemetry/core/platform.py View 3 chunks +0 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/internal/browser/browser.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
Rick Byers
Created Revert of [Pywebsocket PerformanceTests 2/2] Add blink_perf.pywebsocket
5 years, 3 months ago (2015-09-10 23:53:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1333153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1333153002/1
5 years, 3 months ago (2015-09-10 23:54:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-10 23:55:27 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f0bb6fbe7b5d06f2d8b507462cf4b156d6aa34be Cr-Commit-Position: refs/heads/master@{#348289}
5 years, 3 months ago (2015-09-10 23:56:03 UTC) #5
nednguyen
On 2015/09/10 23:56:03, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
5 years, 3 months ago (2015-09-11 00:39:03 UTC) #6
hiroshige
On 2015/09/11 00:39:03, nednguyen wrote: > On 2015/09/10 23:56:03, commit-bot: I haz the power wrote: ...
5 years, 3 months ago (2015-09-11 04:24:51 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:16:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0bb6fbe7b5d06f2d8b507462cf4b156d6aa34be
Cr-Commit-Position: refs/heads/master@{#348289}

Powered by Google App Engine
This is Rietveld 408576698