Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 133313005: Revert of Make flow event traces disabled-by-default, and rename "ipc" and "task" (Closed)

Created:
6 years, 10 months ago by fmeawad
Modified:
6 years, 10 months ago
CC:
chromium-reviews, jam, erikwright+watch_chromium.org, sadrul, darin-cc_chromium.org, tonyg
Visibility:
Public.

Description

Revert of Make flow event traces disabled-by-default, and rename "ipc" and "task" categories to "toplevel" (https://codereview.chromium.org/148173011/) Reason for revert: This is causing a Blink test to fail The test probably just need to update is expectations. Original issue's description: > Make flow event traces disabled-by-default > > Currently all flow events are in the category "toplevel.flow", they originated from "ipc" and "task" categories. > > BUG=338427 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249450 TBR=nduca@chromium.org,jam@chromium.org,willchan@chromium.org,mark@chromium.org,phajdan.jr@chromium.org NOTREECHECKS=true NOTRY=true BUG=341641

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -28 lines) Patch
M base/debug/trace_event_memory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/debug/trace_event_memory_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/message_loop/incoming_task_queue.cc View 1 chunk +1 line, -2 lines 0 comments Download
M base/message_loop/message_loop.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M base/message_loop/message_pump_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/sequenced_worker_pool.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M base/threading/worker_pool_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/worker_pool_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_channel_reader.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ipc/ipc_message.h View 1 chunk +2 lines, -4 lines 0 comments Download
M ipc/ipc_sync_channel.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
fmeawad
Created Revert of Make flow event traces disabled-by-default, and rename "ipc" and "task" categories to ...
6 years, 10 months ago (2014-02-06 23:18:46 UTC) #1
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-06 23:20:34 UTC) #2
fmeawad
The CQ bit was checked by fmeawad@chromium.org
6 years, 10 months ago (2014-02-06 23:25:27 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-06 23:29:36 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-06 23:29:37 UTC) #5
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698