fpdfsdk/include/javascript/global.h - Issue 1332973002: Remove some abstractions in fxjs_v8.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/include/javascript/global.h

Issue 1332973002: Remove some abstractions in fxjs_v8.h. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Remove implicit cast operator from CJS_Runtime. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/include/javascript/global.h

diff --git a/fpdfsdk/include/javascript/global.h b/fpdfsdk/include/javascript/global.h

index 7f78bb6bcbb7520155e7a56354a52fd0fd17ec13..10300a25ab5607cbea7040006fe7e32337645307 100644

--- a/fpdfsdk/include/javascript/global.h

+++ b/fpdfsdk/include/javascript/global.h

@@ -63,7 +63,7 @@ class JSGlobalAlternate : public CJS_EmbedObj {

double dData,

bool bData,

const CFX_ByteString& sData,

- JSObject pData,

+ v8::Local<v8::Object> pData,

bool bDefaultPersistent);

void ObjectToArray(v8::Local<v8::Object> pObj,

@@ -79,7 +79,7 @@ class JSGlobalAlternate : public CJS_EmbedObj {

class CJS_Global : public CJS_Object {

public:

- explicit CJS_Global(JSFXObject pObject) : CJS_Object(pObject) {}

+ explicit CJS_Global(v8::Local<v8::Object> pObject) : CJS_Object(pObject) {}

~CJS_Global() override {}

// CJS_Object

« no previous file with comments | « fpdfsdk/include/javascript/event.h ('k') | fpdfsdk/include/javascript/report.h » ('j') | no next file with comments »