[tracing] Smaps provider uses fscanf instead of istream

base/trace_event/process_memory_maps_dump_provider.h

Index: base/trace_event/process_memory_maps_dump_provider.h
diff --git a/base/trace_event/process_memory_maps_dump_provider.h b/base/trace_event/process_memory_maps_dump_provider.h
index 5a0f84cbb66e0122615b13ccedb031da8fb13fb8..989cb712d66a5baedeedf82b0e367b929dce428b 100644
--- a/base/trace_event/process_memory_maps_dump_provider.h
+++ b/base/trace_event/process_memory_maps_dump_provider.h
@@ -5,12 +5,14 @@
 #ifndef BASE_TRACE_EVENT_PROCESS_MEMORY_MAPS_DUMP_PROVIDER_H_
 #define BASE_TRACE_EVENT_PROCESS_MEMORY_MAPS_DUMP_PROVIDER_H_
 
-#include <istream>
-
 #include "base/gtest_prod_util.h"
 #include "base/memory/singleton.h"
 #include "base/trace_event/memory_dump_provider.h"
 
+#if defined(OS_LINUX) || defined(OS_ANDROID)
+#include "base/files/scoped_file.h"
+#endif
+
 namespace base {
 namespace trace_event {
 
@@ -28,7 +30,7 @@ class BASE_EXPORT ProcessMemoryMapsDumpProvider : public MemoryDumpProvider {
   FRIEND_TEST_ALL_PREFIXES(ProcessMemoryMapsDumpProviderTest, ParseProcSmaps);
 
 #if defined(OS_LINUX) || defined(OS_ANDROID)
-  static std::istream* proc_smaps_for_testing;
+  static ScopedFILE* proc_smaps_for_testing;
 #endif

[Primiano Tucci (use gerrit), 2015/09/30 09:37:02]

Not sure I understand why a pointer to a ScopedFILE?
Either a ScopedFILE (this takes ownership) or a FILE* plz.
Probably the former

[ssid, 2015/09/30 11:15:13]

I can't have static ScopedFILE since it needs exit time destructor, as I
mentioned in previous comment. I have to use some kind of lazy init and it just
becomes harder to differentiate from test and normal mode, also this adds extra
variable in production code.
Making it FILE*

[Primiano Tucci (use gerrit), 2015/09/30 15:36:35]

Acknowledged.

 
   ProcessMemoryMapsDumpProvider();