Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Side by Side Diff: base/trace_event/process_memory_maps_dump_provider.h

Issue 1332943002: [tracing] Smaps provider uses fscanf instead of istream (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/trace_event/process_memory_maps_dump_provider.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_TRACE_EVENT_PROCESS_MEMORY_MAPS_DUMP_PROVIDER_H_ 5 #ifndef BASE_TRACE_EVENT_PROCESS_MEMORY_MAPS_DUMP_PROVIDER_H_
6 #define BASE_TRACE_EVENT_PROCESS_MEMORY_MAPS_DUMP_PROVIDER_H_ 6 #define BASE_TRACE_EVENT_PROCESS_MEMORY_MAPS_DUMP_PROVIDER_H_
7 7
8 #include <istream>
9
10 #include "base/gtest_prod_util.h" 8 #include "base/gtest_prod_util.h"
11 #include "base/memory/singleton.h" 9 #include "base/memory/singleton.h"
12 #include "base/trace_event/memory_dump_provider.h" 10 #include "base/trace_event/memory_dump_provider.h"
13 11
12 #if defined(OS_LINUX) || defined(OS_ANDROID)
13 #include "base/files/scoped_file.h"
14 #endif
15
14 namespace base { 16 namespace base {
15 namespace trace_event { 17 namespace trace_event {
16 18
17 // Dump provider which collects process-wide memory stats. 19 // Dump provider which collects process-wide memory stats.
18 class BASE_EXPORT ProcessMemoryMapsDumpProvider : public MemoryDumpProvider { 20 class BASE_EXPORT ProcessMemoryMapsDumpProvider : public MemoryDumpProvider {
19 public: 21 public:
20 static ProcessMemoryMapsDumpProvider* GetInstance(); 22 static ProcessMemoryMapsDumpProvider* GetInstance();
21 23
22 // MemoryDumpProvider implementation. 24 // MemoryDumpProvider implementation.
23 bool OnMemoryDump(const MemoryDumpArgs& args, 25 bool OnMemoryDump(const MemoryDumpArgs& args,
24 ProcessMemoryDump* pmd) override; 26 ProcessMemoryDump* pmd) override;
25 27
26 private: 28 private:
27 friend struct DefaultSingletonTraits<ProcessMemoryMapsDumpProvider>; 29 friend struct DefaultSingletonTraits<ProcessMemoryMapsDumpProvider>;
28 FRIEND_TEST_ALL_PREFIXES(ProcessMemoryMapsDumpProviderTest, ParseProcSmaps); 30 FRIEND_TEST_ALL_PREFIXES(ProcessMemoryMapsDumpProviderTest, ParseProcSmaps);
29 31
30 #if defined(OS_LINUX) || defined(OS_ANDROID) 32 #if defined(OS_LINUX) || defined(OS_ANDROID)
31 static std::istream* proc_smaps_for_testing; 33 static FILE* proc_smaps_for_testing;
32 #endif 34 #endif
33 35
34 ProcessMemoryMapsDumpProvider(); 36 ProcessMemoryMapsDumpProvider();
35 ~ProcessMemoryMapsDumpProvider() override; 37 ~ProcessMemoryMapsDumpProvider() override;
36 38
37 DISALLOW_COPY_AND_ASSIGN(ProcessMemoryMapsDumpProvider); 39 DISALLOW_COPY_AND_ASSIGN(ProcessMemoryMapsDumpProvider);
38 }; 40 };
39 41
40 } // namespace trace_event 42 } // namespace trace_event
41 } // namespace base 43 } // namespace base
42 44
43 #endif // BASE_TRACE_EVENT_PROCESS_MEMORY_MAPS_DUMP_PROVIDER_H_ 45 #endif // BASE_TRACE_EVENT_PROCESS_MEMORY_MAPS_DUMP_PROVIDER_H_
OLDNEW
« no previous file with comments | « no previous file | base/trace_event/process_memory_maps_dump_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698