Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/gpu/GrOvalRenderer.cpp

Issue 1332923003: Remove batchtracker (Closed) Base URL: https://skia.googlesource.com/skia.git@latecreatepathprocessor
Patch Set: tweaks Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/gpu/GrDefaultGeoProcFactory.cpp ('K') | « src/gpu/GrGpu.h ('k') | src/gpu/GrPathProcessor.h » ('j') | src/gpu/GrTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/GrOvalRenderer.cpp
diff --git a/src/gpu/GrOvalRenderer.cpp b/src/gpu/GrOvalRenderer.cpp
index 34d3db8924e5b495389fce72fe7a2bb8a2dac918..05a1f536f9908119ceffd7790557a381c6a84618 100644
--- a/src/gpu/GrOvalRenderer.cpp
+++ b/src/gpu/GrOvalRenderer.cpp
@@ -89,8 +89,7 @@ public:
class GLProcessor : public GrGLGeometryProcessor {
public:
- GLProcessor(const GrGeometryProcessor&,
- const GrBatchTracker&)
+ GLProcessor()
: fColor(GrColor_ILLEGAL) {}
void onEmitCode(EmitArgs& args, GrGPArgs* gpArgs) override{
@@ -130,7 +129,6 @@ public:
}
static void GenKey(const GrGeometryProcessor& gp,
- const GrBatchTracker& bt,
const GrGLSLCaps&,
GrProcessorKeyBuilder* b) {
const CircleEdgeEffect& ce = gp.cast<CircleEdgeEffect>();
@@ -141,8 +139,7 @@ public:
}
virtual void setData(const GrGLProgramDataManager& pdman,
- const GrPrimitiveProcessor& gp,
- const GrBatchTracker& bt) override {
+ const GrPrimitiveProcessor& gp) override {
const CircleEdgeEffect& ce = gp.cast<CircleEdgeEffect>();
if (ce.color() != fColor) {
GrGLfloat c[4];
@@ -165,15 +162,13 @@ public:
typedef GrGLGeometryProcessor INHERITED;
};
- virtual void getGLProcessorKey(const GrBatchTracker& bt,
- const GrGLSLCaps& caps,
+ virtual void getGLProcessorKey(const GrGLSLCaps& caps,
GrProcessorKeyBuilder* b) const override {
- GLProcessor::GenKey(*this, bt, caps, b);
+ GLProcessor::GenKey(*this, caps, b);
}
- virtual GrGLPrimitiveProcessor* createGLInstance(const GrBatchTracker& bt,
- const GrGLSLCaps&) const override {
- return new GLProcessor(*this, bt);
+ virtual GrGLPrimitiveProcessor* createGLInstance(const GrGLSLCaps&) const override {
bsalomon 2015/09/10 18:55:30 -virtual
joshualitt 2015/09/10 20:08:05 Acknowledged.
+ return new GLProcessor();
}
private:
@@ -243,8 +238,7 @@ public:
class GLProcessor : public GrGLGeometryProcessor {
public:
- GLProcessor(const GrGeometryProcessor&,
- const GrBatchTracker&)
+ GLProcessor()
: fColor(GrColor_ILLEGAL) {}
void onEmitCode(EmitArgs& args, GrGPArgs* gpArgs) override{
@@ -305,7 +299,6 @@ public:
}
static void GenKey(const GrGeometryProcessor& gp,
- const GrBatchTracker& bt,
const GrGLSLCaps&,
GrProcessorKeyBuilder* b) {
const EllipseEdgeEffect& ee = gp.cast<EllipseEdgeEffect>();
@@ -316,8 +309,7 @@ public:
}
virtual void setData(const GrGLProgramDataManager& pdman,
- const GrPrimitiveProcessor& gp,
- const GrBatchTracker& bt) override {
+ const GrPrimitiveProcessor& gp) override {
const EllipseEdgeEffect& ee = gp.cast<EllipseEdgeEffect>();
if (ee.color() != fColor) {
GrGLfloat c[4];
@@ -341,15 +333,13 @@ public:
typedef GrGLGeometryProcessor INHERITED;
};
- virtual void getGLProcessorKey(const GrBatchTracker& bt,
- const GrGLSLCaps& caps,
+ virtual void getGLProcessorKey(const GrGLSLCaps& caps,
GrProcessorKeyBuilder* b) const override {
- GLProcessor::GenKey(*this, bt, caps, b);
+ GLProcessor::GenKey(*this, caps, b);
}
- virtual GrGLPrimitiveProcessor* createGLInstance(const GrBatchTracker& bt,
- const GrGLSLCaps&) const override {
- return new GLProcessor(*this, bt);
+ virtual GrGLPrimitiveProcessor* createGLInstance(const GrGLSLCaps&) const override {
bsalomon 2015/09/10 18:55:30 -virtual?
joshualitt 2015/09/10 20:08:04 Acknowledged.
+ return new GLProcessor();
}
private:
@@ -425,8 +415,7 @@ public:
class GLProcessor : public GrGLGeometryProcessor {
public:
- GLProcessor(const GrGeometryProcessor&,
- const GrBatchTracker&)
+ GLProcessor()
: fViewMatrix(SkMatrix::InvalidMatrix()), fColor(GrColor_ILLEGAL) {}
void onEmitCode(EmitArgs& args, GrGPArgs* gpArgs) override{
@@ -502,7 +491,6 @@ public:
}
static void GenKey(const GrGeometryProcessor& gp,
- const GrBatchTracker& bt,
const GrGLSLCaps&,
GrProcessorKeyBuilder* b) {
const DIEllipseEdgeEffect& ellipseEffect = gp.cast<DIEllipseEdgeEffect>();
@@ -513,8 +501,7 @@ public:
}
virtual void setData(const GrGLProgramDataManager& pdman,
bsalomon 2015/09/10 18:55:30 -virtual?
joshualitt 2015/09/10 20:08:04 Acknowledged.
- const GrPrimitiveProcessor& gp,
- const GrBatchTracker& bt) override {
+ const GrPrimitiveProcessor& gp) override {
const DIEllipseEdgeEffect& dee = gp.cast<DIEllipseEdgeEffect>();
if (!dee.viewMatrix().isIdentity() && !fViewMatrix.cheapEqualTo(dee.viewMatrix())) {
@@ -541,15 +528,13 @@ public:
typedef GrGLGeometryProcessor INHERITED;
};
- virtual void getGLProcessorKey(const GrBatchTracker& bt,
- const GrGLSLCaps& caps,
+ virtual void getGLProcessorKey(const GrGLSLCaps& caps,
GrProcessorKeyBuilder* b) const override {
- GLProcessor::GenKey(*this, bt, caps, b);
+ GLProcessor::GenKey(*this, caps, b);
}
- virtual GrGLPrimitiveProcessor* createGLInstance(const GrBatchTracker& bt,
- const GrGLSLCaps&) const override {
- return new GLProcessor(*this, bt);
+ virtual GrGLPrimitiveProcessor* createGLInstance(const GrGLSLCaps&) const override {
+ return new GLProcessor();
}
private:
« src/gpu/GrDefaultGeoProcFactory.cpp ('K') | « src/gpu/GrGpu.h ('k') | src/gpu/GrPathProcessor.h » ('j') | src/gpu/GrTest.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698