Fixing Sloppy Symbol.iterator setter

Fixing Sloppy Symbol.iterator setter
In certiain cases the ArgumentsIteratorSetter would trigger an invalid
state in the LookupIterator when being overridden. This is now solved
by bypassing the SetDataProperty and directly using
DefinePropertyOrElementIgnoringAttributes since we know exactly which
property we're going to install

LOG=N
BUG=chromium:521484
Committed: https://crrev.com/2f1df49a6c51cfe267e22e8442e34d59514324a2
Cr-Commit-Position: refs/heads/master@{#30705}

[Camillo Bruni, 2015-09-10 13:59:48]

cbruni@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Camillo Bruni, 2015-09-10 13:59:48]

PTAL

https://codereview.chromium.org/1332873002/diff/1/src/accessors.cc
File src/accessors.cc (right):

https://codereview.chromium.org/1332873002/diff/1/src/accessors.cc#newcode155
src/accessors.cc:155: .Check();
I am not fully sure if and how I should check for exceptions here...

https://codereview.chromium.org/1332873002/diff/1/test/mjsunit/es6/arguments-...
File test/mjsunit/es6/arguments-iterator.js (right):

https://codereview.chromium.org/1332873002/diff/1/test/mjsunit/es6/arguments-...
test/mjsunit/es6/arguments-iterator.js:163: function TestAssignmentToIterator2()
{
Do you add a regression/?? comment here?

[Jakob Kummerow, 2015-09-10 14:29:20]

LGTM with comments.

https://codereview.chromium.org/1332873002/diff/1/src/accessors.cc
File src/accessors.cc (right):

https://codereview.chromium.org/1332873002/diff/1/src/accessors.cc#newcode155
src/accessors.cc:155: .Check();
On 2015/09/10 13:59:48, cbruni wrote:
> I am not fully sure if and how I should check for exceptions here...

if: yes, I think you should. (Rule of thumb: if a CHECK or .Check() ever fails
in production, it's a bug. It's conceivable that this one might fail.)
how: like the old code did. If the MaybeHandle is_null(), call
isolate->OptionalRescheduleException.

https://codereview.chromium.org/1332873002/diff/1/test/mjsunit/es6/arguments-...
File test/mjsunit/es6/arguments-iterator.js (right):

https://codereview.chromium.org/1332873002/diff/1/test/mjsunit/es6/arguments-...
test/mjsunit/es6/arguments-iterator.js:163: function TestAssignmentToIterator2()
{
On 2015/09/10 13:59:48, cbruni wrote:
> Do you add a regression/?? comment here?

You certainly can. There's no formal syntax, I'd just write:

// Regression test for crbug.com/521484.

https://codereview.chromium.org/1332873002/diff/1/test/mjsunit/es6/arguments-...
test/mjsunit/es6/arguments-iterator.js:176: 
nit: two empty lines between top-level things

[Camillo Bruni, 2015-09-14 06:49:47]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-14 06:49:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1332873002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1332873002/20001

[commit-bot: I haz the power, 2015-09-14 07:15:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 07:15:36]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2015-09-14 07:18:43]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2015-09-14 07:18:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1332873002/#ps20001
(title: "adding error handling")

[commit-bot: I haz the power, 2015-09-14 07:18:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1332873002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1332873002/20001

[commit-bot: I haz the power, 2015-09-14 07:20:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-14 07:22:46]

Patchset 2 (id:??) landed as
https://crrev.com/2f1df49a6c51cfe267e22e8442e34d59514324a2
Cr-Commit-Position: refs/heads/master@{#30705}