Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 1332753002: BrowserPluginGuest should carry the correct text input states when notifying the text input type cha (Closed)

Created:
5 years, 3 months ago by Shu Chen
Modified:
5 years, 2 months ago
Reviewers:
Fady Samuel, jam
CC:
chromium-reviews, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

BrowserPluginGuest should carry the correct text input states when notifying the text input type changed. Especially for show_ime_if_needed value. Always passing false caused the bug. BUG=528512 TEST=The bug not repro with this cl. Committed: https://crrev.com/f93c297af1ae9e4b2638de7c4b9ebb039c02ef9c Cr-Commit-Position: refs/heads/master@{#348311}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -18 lines) Patch
M content/browser/browser_plugin/browser_plugin_guest.h View 1 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 3 chunks +3 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Shu Chen
Can you please help to review this cl? Thanks
5 years, 3 months ago (2015-09-10 07:46:18 UTC) #2
jam
On 2015/09/10 07:46:18, Shu Chen wrote: > Can you please help to review this cl? ...
5 years, 3 months ago (2015-09-10 19:26:04 UTC) #3
Fady Samuel
As a browser_plugin OWNER, drive-by LGTM :-)
5 years, 3 months ago (2015-09-10 19:27:14 UTC) #5
Shu Chen
On 2015/09/10 19:27:14, Fady Samuel wrote: > As a browser_plugin OWNER, drive-by LGTM :-) Thanks!
5 years, 3 months ago (2015-09-11 00:41:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332753002/20001
5 years, 3 months ago (2015-09-11 00:41:28 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-11 01:52:47 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f93c297af1ae9e4b2638de7c4b9ebb039c02ef9c Cr-Commit-Position: refs/heads/master@{#348311}
5 years, 3 months ago (2015-09-11 01:53:29 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 12:17:41 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f93c297af1ae9e4b2638de7c4b9ebb039c02ef9c
Cr-Commit-Position: refs/heads/master@{#348311}

Powered by Google App Engine
This is Rietveld 408576698