Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1332743002: Generalize ScopedDisposal<T> to handle non-GC types. (Closed)

Created:
5 years, 3 months ago by sof
Modified:
5 years, 3 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Generalize ScopedDisposal<T> to handle non-GC types. Drop the restriction that ScopedDisposal<T> can only be used with Oilpan GCed types + parameterize the template over the disposal method to use (with dispose() being the default.) R=haraken BUG= Committed: https://crrev.com/e16acf7a0632169dec82898061a2773b8eff86cf git-svn-id: svn://svn.chromium.org/blink/trunk@202048 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M Source/platform/heap/Handle.h View 1 chunk +15 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
sof
please take a look. This template should migrate to wtf/ eventually (or some such.)
5 years, 3 months ago (2015-09-10 06:56:39 UTC) #2
haraken
LGTM
5 years, 3 months ago (2015-09-10 06:57:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332743002/1
5 years, 3 months ago (2015-09-10 07:12:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/67045)
5 years, 3 months ago (2015-09-10 09:55:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332743002/1
5 years, 3 months ago (2015-09-10 10:51:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202048
5 years, 3 months ago (2015-09-10 11:56:49 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:09:50 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e16acf7a0632169dec82898061a2773b8eff86cf

Powered by Google App Engine
This is Rietveld 408576698