Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: chromeos/ime/input_method_manager.h

Issue 133273032: Guest Mode: input method should default to the underlying latin keyboard layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed bool login_layouts_only option from EnableLayouts(); EnableLayouts => EnableLoginLayouts. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/ime/input_method_manager.h
diff --git a/chromeos/ime/input_method_manager.h b/chromeos/ime/input_method_manager.h
index f293882e0b51152335ef824901033b1e08b5edbb..a33501d13b1b9ff20d7b935f1e52b4f29d5ae941 100644
--- a/chromeos/ime/input_method_manager.h
+++ b/chromeos/ime/input_method_manager.h
@@ -109,16 +109,16 @@ class CHROMEOS_EXPORT InputMethodManager {
// is not active, switch to the first one in the active input method list.
virtual void ChangeInputMethod(const std::string& input_method_id) = 0;
- // Enables keyboard layouts (e.g. US Qwerty, US Dvorak, French Azerty) that
- // are necessary for the |language_code| and then switches to |initial_layout|
- // if the string is not empty. For example, if |language_code| is "en-US", US
- // Qwerty, US International, US Extended, US Dvorak, and US Colemak layouts
- // would be enabled. Likewise, for Germany locale, US Qwerty which corresponds
- // to the hardware keyboard layout and several keyboard layouts for Germany
- // would be enabled.
- // This method is for setting up i18n keyboard layouts for the login screen.
- virtual void EnableLayouts(const std::string& language_code,
- const std::string& initial_layout) = 0;
+ // Enables "login" keyboard layouts (e.g. US Qwerty, US Dvorak, French
+ // Azerty) that are necessary for the |language_code| and then switches to
+ // |initial_layout| if the string is not empty. For example, if
+ // |language_code| is "en-US", US Qwerty, US International, US Extended, US
+ // Dvorak, and US Colemak layouts would be enabled. Likewise, for Germany
+ // locale, US Qwerty which corresponds to the hardware keyboard layout and
+ // several keyboard layouts for Germany would be enabled.
+ // Only layouts suitable for login screen are enabled.
+ virtual void EnableLoginLayouts(const std::string& language_code,
+ const std::string& initial_layout) = 0;
// Activates the input method property specified by the |key|.
virtual void ActivateInputMethodProperty(const std::string& key) = 0;

Powered by Google App Engine
This is Rietveld 408576698