chrome/browser/chromeos/input_method/input_method_util.h - Issue 133273032: Guest Mode: input method should default to the underlying latin keyboard layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/input_method_util.h

Issue 133273032: Guest Mode: input method should default to the underlying latin keyboard layout. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed owner's layouts from Guest mode. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc ('k') | chrome/browser/chromeos/input_method/input_method_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/input_method_util.h

diff --git a/chrome/browser/chromeos/input_method/input_method_util.h b/chrome/browser/chromeos/input_method/input_method_util.h

index 32f3efbc177d4163c19cc8dcb538a00256da63b3..01b913f6391b2355efbd7dc17194cf3d9a93be6f 100644

--- a/chrome/browser/chromeos/input_method/input_method_util.h

+++ b/chrome/browser/chromeos/input_method/input_method_util.h

@@ -93,10 +93,19 @@ class InputMethodUtil {

const std::vector<std::string>& input_method_ids,

std::vector<std::string>* out_language_codes) const;

+ // Gets first input method associated with the language.

+ // Returns empty string on error.

+ std::string GetLanguageDefaultInputMethodId(const std::string& language_code);

// Returns the input method ID of the hardware keyboard. e.g. "xkb:us::eng"

// for the US Qwerty keyboard.

std::string GetHardwareInputMethodId() const;

+ // Returns the login-allowed input method ID of the hardware keyboard.

+ std::string GetHardwareLoginInputMethodId() const;

+ bool IsLoginKeyboard(const std::string& layout) const;

Hiro Komatsu 2014/01/22 10:01:55 Please add comment and unittest. layout -> input_

Alexander Alekseev 2014/01/22 11:35:05 Done.

// Returns true if the given input method id is supported.

bool IsValidInputMethodId(const std::string& input_method_id) const;