Guest Mode: input method should default to the underlying latin keyboard layout.

chromeos/ime/input_method_manager.h

Index: chromeos/ime/input_method_manager.h
diff --git a/chromeos/ime/input_method_manager.h b/chromeos/ime/input_method_manager.h
index f293882e0b51152335ef824901033b1e08b5edbb..7dd2d49b6b1ea590ccec8f094b37dfce671250c4 100644
--- a/chromeos/ime/input_method_manager.h
+++ b/chromeos/ime/input_method_manager.h
@@ -116,9 +116,11 @@ class CHROMEOS_EXPORT InputMethodManager {
   // would be enabled. Likewise, for Germany locale, US Qwerty which corresponds
   // to the hardware keyboard layout and several keyboard layouts for Germany
   // would be enabled.
-  // This method is for setting up i18n keyboard layouts for the login screen.
+  //   For the login screen you need login_layouts_only=true to filter
+  // unsuitable keyboard layouts.
   virtual void EnableLayouts(const std::string& language_code,

[Hiro Komatsu, 2014/01/21 05:46:01]

To add keyboard layouts after login, please use EnableInputMethod(s).

[Alexander Alekseev, 2014/01/21 14:05:27]

What do you mean? This method has always been used for loading locale layouts
after locale switch. It happens only once after user logs in and before browser
starts.

EnableInputMethod(s) doesn't accept locale.

[Hiro Komatsu, 2014/01/22 10:01:55]

InputMethodUtil::GetInputMethodIdsFromLanguageCode converts language_code to
input_method_id.

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/chr...


I prefer to use the above function in the caller or add a new function (if
necessary), rather than a boolean flag of login_layouts_only in this case.

[Alexander Alekseev, 2014/01/22 11:35:05]

Do you prefer to move EnableLayouts(const std::string& language_code) away from
input manager? Probably I don't understand you:
  There is a moment, when we need to completely replace list of active input
methods by new. We need to calculate this list from different data, including
active locale, active layout and required mode. Or, more generally, from device
settings and user settings.
So, now we have settings selection in chromeos/login code, and input methods
selection (based on these settings) in InputMethodManager::EnableLayouts() code.

  Do you mean, we should eliminate EnableLayouts(), move input methods selection
to chromeos/login code, and use EnableInputMethods from chromeos/login code to
replace enabled methods?

[Hiro Komatsu, 2014/01/24 08:24:44]

No, what I meant were:

1. Please do not use EnableLayouts to add non login layouts.
1-1. So please do not add the login_layouts_only flag.

2. Please use EnableInputMethod to add non login layouts.
2-1. InputMethodUtil::GetInputMethodIdsFromLanguageCode converts language_code
to input_method_id.
2-2. If necessary, please use both EnableLayouts and EnableInputMethod to switch
the whole input methods.
(2-3. If necessary, please make a new function to perform 2-2 instead of adding
a flag.)


I admit those function names are confusing due to the historical reason.  It
would be a good time to rename them.

 
I did not mean so.

[Alexander Alekseev, 2014/01/24 13:29:45]

Done.

-                             const std::string& initial_layout) = 0;
+                             const std::string& initial_layout,
+                             const bool login_layouts_only) = 0;
 
   // Activates the input method property specified by the |key|.
   virtual void ActivateInputMethodProperty(const std::string& key) = 0;