Guest Mode: input method should default to the underlying latin keyboard layout.

chromeos/ime/input_method_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_IME_INPUT_METHOD_MANAGER_H_
 #define CHROMEOS_IME_INPUT_METHOD_MANAGER_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 98 matching lines @@
   // is not active, switch to the first one in the active input method list.
   virtual void ChangeInputMethod(const std::string& input_method_id) = 0;
 
   // Enables keyboard layouts (e.g. US Qwerty, US Dvorak, French Azerty) that
   // are necessary for the |language_code| and then switches to |initial_layout|
   // if the string is not empty. For example, if |language_code| is "en-US", US
   // Qwerty, US International, US Extended, US Dvorak, and US Colemak layouts
   // would be enabled. Likewise, for Germany locale, US Qwerty which corresponds
   // to the hardware keyboard layout and several keyboard layouts for Germany
   // would be enabled.
-  // This method is for setting up i18n keyboard layouts for the login screen.
+  //   For the login screen you need login_layouts_only=true to filter
+  // unsuitable keyboard layouts.
   virtual void EnableLayouts(const std::string& language_code,

[Hiro Komatsu, 2014/01/21 05:46:01]

To add keyboard layouts after login, please use EnableInputMethod(s).

[Alexander Alekseev, 2014/01/21 14:05:27]

What do you mean? This method has always been used for loading locale layouts
after locale switch. It happens only once after user logs in and before browser
starts.

EnableInputMethod(s) doesn't accept locale.

[Hiro Komatsu, 2014/01/22 10:01:55]

InputMethodUtil::GetInputMethodIdsFromLanguageCode converts language_code to
input_method_id.

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/chr...


I prefer to use the above function in the caller or add a new function (if
necessary), rather than a boolean flag of login_layouts_only in this case.

[Alexander Alekseev, 2014/01/22 11:35:05]

Do you prefer to move EnableLayouts(const std::string& language_code) away from
input manager? Probably I don't understand you:
  There is a moment, when we need to completely replace list of active input
methods by new. We need to calculate this list from different data, including
active locale, active layout and required mode. Or, more generally, from device
settings and user settings.
So, now we have settings selection in chromeos/login code, and input methods
selection (based on these settings) in InputMethodManager::EnableLayouts() code.

  Do you mean, we should eliminate EnableLayouts(), move input methods selection
to chromeos/login code, and use EnableInputMethods from chromeos/login code to
replace enabled methods?

[Hiro Komatsu, 2014/01/24 08:24:44]

No, what I meant were:

1. Please do not use EnableLayouts to add non login layouts.
1-1. So please do not add the login_layouts_only flag.

2. Please use EnableInputMethod to add non login layouts.
2-1. InputMethodUtil::GetInputMethodIdsFromLanguageCode converts language_code
to input_method_id.
2-2. If necessary, please use both EnableLayouts and EnableInputMethod to switch
the whole input methods.
(2-3. If necessary, please make a new function to perform 2-2 instead of adding
a flag.)


I admit those function names are confusing due to the historical reason.  It
would be a good time to rename them.

 
I did not mean so.

[Alexander Alekseev, 2014/01/24 13:29:45]

Done.

-                             const std::string& initial_layout) = 0;
+                             const std::string& initial_layout,
+                             const bool login_layouts_only) = 0;
 
   // Activates the input method property specified by the |key|.
   virtual void ActivateInputMethodProperty(const std::string& key) = 0;
 
   // Updates the list of active input method IDs, and then starts or stops the
   // system input method framework as needed.
   virtual bool EnableInputMethods(
       const std::vector<std::string>& new_active_input_method_ids) = 0;
 
   // Adds one entry to the list of active input method IDs, and then starts or
@@ skipping 51 matching lines @@
   virtual bool SwitchInputMethod(const ui::Accelerator& accelerator) = 0;
 
   // If keyboard layout can be uset at login screen
   virtual bool IsLoginKeyboard(const std::string& layout) const = 0;
 };
 
 }  // namespace input_method
 }  // namespace chromeos
 
 #endif  // CHROMEOS_IME_INPUT_METHOD_MANAGER_H_