Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: public/web/WebViewClient.h

Issue 133273030: Change a WebString type of url parameter with WebURL (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/web/WebViewClient.h
diff --git a/public/web/WebViewClient.h b/public/web/WebViewClient.h
index 4a8cd89a0036bcccba5ae03f9f4511416d60f70d..9df6415d459101801086a9d19f3eae2722638fc7 100644
--- a/public/web/WebViewClient.h
+++ b/public/web/WebViewClient.h
@@ -353,16 +353,13 @@ public:
virtual void zoomLevelChanged() { }
// Registers a new URL handler for the given protocol.
- virtual void registerProtocolHandler(const WebString& scheme,
- const WebString& baseUrl,
- const WebString& url,
- const WebString& title) { }
+ virtual void registerProtocolHandler(const WebString& scheme, const WebURL& baseUrl, const WebURL& url, const WebString& title) { }
jochen (gone - plz use gerrit) 2014/01/20 09:21:38 please keep the old version around and have the ne
gyuyoung-inactive 2014/01/21 02:17:14 Jochen, can't we land blink's cl and content's cl
// Unregisters a given URL handler for the given protocol.
- virtual void unregisterProtocolHandler(const WebString& scheme, const WebString& baseUrl, const WebString& url) { }
+ virtual void unregisterProtocolHandler(const WebString& scheme, const WebURL& baseUrl, const WebURL& url) { }
// Check if a given URL handler is registered for the given protocol.
- virtual WebCustomHandlersState isProtocolHandlerRegistered(const WebString& scheme, const WebString& baseUrl, const WebString& url)
+ virtual WebCustomHandlersState isProtocolHandlerRegistered(const WebString& scheme, const WebURL& baseUrl, const WebURL& url)
{
return WebCustomHandlersNew;
}

Powered by Google App Engine
This is Rietveld 408576698