Change a WebString type of url parameter with WebURL

Change a url parameter type with WebURL

As mentioned in https://codereview.chromium.org/18179009/#msg7, it would be good if we use WebURL for url parameters instead of using WebString. This cl change it with WebURL.

BUG=N/A

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165458

[gyuyoung-inactive, 2014-01-20 06:23:12]

Abarth, regarding you pointed out before, this cl is to use WebURL for url
parameter in APIs related to the navigator content util feature.

[gyuyoung-inactive, 2014-01-20 06:26:13]

On 2014/01/20 06:23:12, gyuyoung wrote:
> Abarth, regarding you pointed out before, this cl is to use WebURL for url
> parameter in APIs related to the navigator content util feature.

After landing this cl, *content* layer should be fixed by 133273030 issue.
https://codereview.chromium.org/133273030/

[jochen (gone - plz use gerrit), 2014-01-20 09:21:38]

https://codereview.chromium.org/133273030/diff/1/Source/modules/navigatorcont...
File Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp (right):

https://codereview.chromium.org/133273030/diff/1/Source/modules/navigatorcont...
Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp:148: if
(!verifyCustomHandlerURL(baseURL.string(), url, exceptionState))
should verifyCustomHandlerURL take a URL as first parameter as well?

https://codereview.chromium.org/133273030/diff/1/public/web/WebViewClient.h
File public/web/WebViewClient.h (right):

https://codereview.chromium.org/133273030/diff/1/public/web/WebViewClient.h#n...
public/web/WebViewClient.h:356: virtual void registerProtocolHandler(const
WebString& scheme, const WebURL& baseUrl, const WebURL& url, const WebString&
title) { }
please keep the old version around and have the new version call the old
version. Otherwise, chrome will be broken until blink rolls and the chrome side
CL lands

[gyuyoung-inactive, 2014-01-21 02:17:14]

https://codereview.chromium.org/133273030/diff/1/Source/modules/navigatorcont...
File Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp (right):

https://codereview.chromium.org/133273030/diff/1/Source/modules/navigatorcont...
Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp:148: if
(!verifyCustomHandlerURL(baseURL.string(), url, exceptionState))
On 2014/01/20 09:21:38, jochen wrote:
> should verifyCustomHandlerURL take a URL as first parameter as well?

Ok, I modify it to use KURL. BTW, don't you think we need to use KURL for *url*
as well ? We need to do more additional work when changing it to use *KURL*
instead of *String*. So, it seems to me it is good to keep to use *String* for
*url* param. How do you think ?

https://codereview.chromium.org/133273030/diff/1/public/web/WebViewClient.h
File public/web/WebViewClient.h (right):

https://codereview.chromium.org/133273030/diff/1/public/web/WebViewClient.h#n...
public/web/WebViewClient.h:356: virtual void registerProtocolHandler(const
WebString& scheme, const WebURL& baseUrl, const WebURL& url, const WebString&
title) { }
Jochen, can't we land blink's cl and content's cl together ? That's why I upload
a patch to 143023002.

https://codereview.chromium.org/143023002/

[jochen (gone - plz use gerrit), 2014-01-21 08:05:34]

On 2014/01/21 02:17:14, gyuyoung wrote:
>
https://codereview.chromium.org/133273030/diff/1/Source/modules/navigatorcont...
> File Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp (right):
> 
>
https://codereview.chromium.org/133273030/diff/1/Source/modules/navigatorcont...
> Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp:148: if
> (!verifyCustomHandlerURL(baseURL.string(), url, exceptionState))
> On 2014/01/20 09:21:38, jochen wrote:
> > should verifyCustomHandlerURL take a URL as first parameter as well?
> 
> Ok, I modify it to use KURL. BTW, don't you think we need to use KURL for
*url*
> as well ? We need to do more additional work when changing it to use *KURL*
> instead of *String*. So, it seems to me it is good to keep to use *String* for
> *url* param. How do you think ?

make sense

> 
> https://codereview.chromium.org/133273030/diff/1/public/web/WebViewClient.h
> File public/web/WebViewClient.h (right):
> 
>
https://codereview.chromium.org/133273030/diff/1/public/web/WebViewClient.h#n...
> public/web/WebViewClient.h:356: virtual void registerProtocolHandler(const
> WebString& scheme, const WebURL& baseUrl, const WebURL& url, const WebString&
> title) { }
> Jochen, can't we land blink's cl and content's cl together ? That's why I
upload
> a patch to 143023002.

No, that's not possible. Chromium (and therefore content) uses the version of
blink as defined in its DEPS file. The blink bots, however, will use ToT blink
ignoring the specified DEPS revision. You need to structure the patches such
that we can compile at all times, i.e. also before the DEPS revision was updated
to include your patch

[gyuyoung-inactive, 2014-01-21 09:18:13]

https://codereview.chromium.org/133273030/diff/140001/public/web/WebViewClient.h
File public/web/WebViewClient.h (right):

https://codereview.chromium.org/133273030/diff/140001/public/web/WebViewClien...
public/web/WebViewClient.h:363: registerProtocolHandler(scheme,
baseUrl.string(), url.string(), title);
Jochen, I change to let new version call old version. But, I'm not sure if this
intermediate implementation can be accepted.

[jochen (gone - plz use gerrit), 2014-01-21 09:29:19]

lgtm

https://codereview.chromium.org/133273030/diff/140001/public/web/WebViewClient.h
File public/web/WebViewClient.h (right):

https://codereview.chromium.org/133273030/diff/140001/public/web/WebViewClien...
public/web/WebViewClient.h:355: // Navigaor Content Utils 
----------------------------------------------
Navigator

[gyuyoung-inactive, 2014-01-21 12:47:39]

On 2014/01/21 09:29:19, jochen wrote:
> lgtm
> 
>
https://codereview.chromium.org/133273030/diff/140001/public/web/WebViewClient.h
> File public/web/WebViewClient.h (right):
> 
>
https://codereview.chromium.org/133273030/diff/140001/public/web/WebViewClien...
> public/web/WebViewClient.h:355: // Navigaor Content Utils 
> ----------------------------------------------
> Navigator

Fixed. Thanks.

[commit-bot: I haz the power, 2014-01-21 12:48:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/133273030/180001

[commit-bot: I haz the power, 2014-01-21 13:50:09]

Change committed as 165458