Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Unified Diff: components/translate/core/browser/translate_client.h

Issue 133273029: Move LanguageState to the translate component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_client.h
diff --git a/components/translate/core/browser/translate_client.h b/components/translate/core/browser/translate_client.h
new file mode 100644
index 0000000000000000000000000000000000000000..09ec0f5447116261fd49ceaa9111a3a1773ebe94
--- /dev/null
+++ b/components/translate/core/browser/translate_client.h
@@ -0,0 +1,31 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_CLIENT_H_
+#define COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_CLIENT_H_
+
+#include "components/translate/core/browser/language_state.h"
+
+class TranslateClient {
blundell 2014/01/17 15:09:39 This needs a class-level comment.
droger 2014/01/17 16:14:21 Done.
+ public:
+ TranslateClient();
+ virtual ~TranslateClient();
+
+ // Gets the language state.
+ LanguageState& GetLanguageState();
+
+ protected:
+ LanguageState language_state_;
blundell 2014/01/17 15:09:39 This should just be in the subclasses I think.
droger 2014/01/17 16:14:21 Done.
+
+ private:
+ // Methods called by LanguageState.
blundell 2014/01/17 15:09:39 Why would these methods be private?
droger 2014/01/17 16:14:21 As discussed offline, it was that nobody can call
+ friend class LanguageState;
+ virtual bool IsLinkNavigation() = 0;
+ virtual void OnTranslateEnabledChanged() = 0;
+ virtual void OnIsPageTranslatedChanged() = 0;
+
+ DISALLOW_COPY_AND_ASSIGN(TranslateClient);
+};
+
+#endif // COMPONENTS_TRANSLATE_CORE_BROWSER_TRANSLATE_CLIENT_H_

Powered by Google App Engine
This is Rietveld 408576698