chrome/browser/ui/views/frame/browser_view.cc - Issue 133273029: Move LanguageState to the translate component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 133273029: Move LanguageState to the translate component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comment + rebase Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index 3c7199ee2f74e9bed2cce06dcc57fee88c352621..f77dde41f15787323485e66cc26e52179ee772ef 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -1208,7 +1208,7 @@ void BrowserView::ShowTranslateBubble(

TranslateErrors::Type error_type) {

TranslateTabHelper* translate_tab_helper =

TranslateTabHelper::FromWebContents(web_contents);

- LanguageState& language_state = translate_tab_helper->language_state();

+ LanguageState& language_state = translate_tab_helper->GetLanguageState();

language_state.SetTranslateEnabled(true);

TranslateBubbleView::ShowBubble(GetToolbarView()->GetTranslateBubbleAnchor(),