chrome/browser/ui/browser_commands.cc - Issue 133273029: Move LanguageState to the translate component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 133273029: Move LanguageState to the translate component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comment + rebase Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_commands.cc

diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc

index 8580a4480bfd1b041685e70dc0685bf3f7d12373..900ed6f5ae49e1e5fe8c784f5ad279ccd0f66cff 100644

--- a/chrome/browser/ui/browser_commands.cc

+++ b/chrome/browser/ui/browser_commands.cc

@@ -696,9 +696,9 @@ void Translate(Browser* browser) {

TranslateBubbleModel::ViewState view_state =

TranslateBubbleModel::VIEW_STATE_BEFORE_TRANSLATE;

if (translate_tab_helper) {

- if (translate_tab_helper->language_state().translation_pending())

+ if (translate_tab_helper->GetLanguageState().translation_pending())

view_state = TranslateBubbleModel::VIEW_STATE_TRANSLATING;

- else if (translate_tab_helper->language_state().IsPageTranslated())

+ else if (translate_tab_helper->GetLanguageState().IsPageTranslated())

view_state = TranslateBubbleModel::VIEW_STATE_AFTER_TRANSLATE;

}

browser->window()->ShowTranslateBubble(web_contents, view_state,