Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Side by Side Diff: chrome/browser/translate/translate_tab_helper.h

Issue 133273029: Move LanguageState to the translate component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_TRANSLATE_TRANSLATE_TAB_HELPER_H_ 5 #ifndef CHROME_BROWSER_TRANSLATE_TRANSLATE_TAB_HELPER_H_
6 #define CHROME_BROWSER_TRANSLATE_TRANSLATE_TAB_HELPER_H_ 6 #define CHROME_BROWSER_TRANSLATE_TRANSLATE_TAB_HELPER_H_
7 7
8 #include "chrome/browser/tab_contents/language_state.h" 8 #include "components/translate/content/browser/content_translate_driver.h"
9 #include "components/translate/core/common/translate_errors.h" 9 #include "components/translate/core/common/translate_errors.h"
10 #include "content/public/browser/web_contents_observer.h" 10 #include "content/public/browser/web_contents_observer.h"
11 #include "content/public/browser/web_contents_user_data.h" 11 #include "content/public/browser/web_contents_user_data.h"
12 12
13 struct LanguageDetectionDetails; 13 struct LanguageDetectionDetails;
14 14
15 class TranslateTabHelper 15 class TranslateTabHelper
16 : public content::WebContentsObserver, 16 : public content::WebContentsObserver,
17 public content::WebContentsUserData<TranslateTabHelper> { 17 public content::WebContentsUserData<TranslateTabHelper> {
18 public: 18 public:
19 virtual ~TranslateTabHelper(); 19 virtual ~TranslateTabHelper();
20 20
21 LanguageState& language_state() { return language_state_; } 21 // Gets the LanguageState associated with the page.
22 // Information about the language the page is in and has been translated to.
blundell 2014/01/17 16:37:36 This comment reads oddly.
droger 2014/01/20 10:37:06 This line was in the original code (line 40 on the
23 LanguageState& GetLanguageState();
24
25 // Returns the content driver for translate.
26 ContentTranslateDriver* GetTranslateDriver();
blundell 2014/01/17 16:37:36 I assume that TranslateTabHelper will get merged w
droger 2014/01/20 10:37:06 If all goes well yes. I still need to sort out the
22 27
23 private: 28 private:
24 explicit TranslateTabHelper(content::WebContents* web_contents); 29 explicit TranslateTabHelper(content::WebContents* web_contents);
25 friend class content::WebContentsUserData<TranslateTabHelper>; 30 friend class content::WebContentsUserData<TranslateTabHelper>;
26 31
27 // content::WebContentsObserver implementation. 32 // content::WebContentsObserver implementation.
28 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE; 33 virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
29 virtual void DidNavigateAnyFrame( 34 virtual void DidNavigateAnyFrame(
30 const content::LoadCommittedDetails& details, 35 const content::LoadCommittedDetails& details,
31 const content::FrameNavigateParams& params) OVERRIDE; 36 const content::FrameNavigateParams& params) OVERRIDE;
32 37
33 void OnLanguageDetermined(const LanguageDetectionDetails& details, 38 void OnLanguageDetermined(const LanguageDetectionDetails& details,
34 bool page_needs_translation); 39 bool page_needs_translation);
35 void OnPageTranslated(int32 page_id, 40 void OnPageTranslated(int32 page_id,
36 const std::string& original_lang, 41 const std::string& original_lang,
37 const std::string& translated_lang, 42 const std::string& translated_lang,
38 TranslateErrors::Type error_type); 43 TranslateErrors::Type error_type);
39 44
40 // Information about the language the page is in and has been translated to. 45 ContentTranslateDriver translate_driver_;
41 LanguageState language_state_;
42 46
43 DISALLOW_COPY_AND_ASSIGN(TranslateTabHelper); 47 DISALLOW_COPY_AND_ASSIGN(TranslateTabHelper);
44 }; 48 };
45 49
46 #endif // CHROME_BROWSER_TRANSLATE_TRANSLATE_TAB_HELPER_H_ 50 #endif // CHROME_BROWSER_TRANSLATE_TRANSLATE_TAB_HELPER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698