Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Side by Side Diff: chrome/browser/ui/browser.cc

Issue 133273029: Move LanguageState to the translate component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comment + rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/browser_browsertest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser.h" 5 #include "chrome/browser/ui/browser.h"
6 6
7 #if defined(OS_WIN) 7 #if defined(OS_WIN)
8 #include <windows.h> 8 #include <windows.h>
9 #include <shellapi.h> 9 #include <shellapi.h>
10 #endif // defined(OS_WIN) 10 #endif // defined(OS_WIN)
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 #include "chrome/browser/themes/theme_service.h" 87 #include "chrome/browser/themes/theme_service.h"
88 #include "chrome/browser/themes/theme_service_factory.h" 88 #include "chrome/browser/themes/theme_service_factory.h"
89 #include "chrome/browser/translate/translate_tab_helper.h" 89 #include "chrome/browser/translate/translate_tab_helper.h"
90 #include "chrome/browser/ui/app_modal_dialogs/javascript_dialog_manager.h" 90 #include "chrome/browser/ui/app_modal_dialogs/javascript_dialog_manager.h"
91 #include "chrome/browser/ui/autofill/tab_autofill_manager_delegate.h" 91 #include "chrome/browser/ui/autofill/tab_autofill_manager_delegate.h"
92 #include "chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h" 92 #include "chrome/browser/ui/blocked_content/popup_blocker_tab_helper.h"
93 #include "chrome/browser/ui/bookmarks/bookmark_tab_helper.h" 93 #include "chrome/browser/ui/bookmarks/bookmark_tab_helper.h"
94 #include "chrome/browser/ui/browser_command_controller.h" 94 #include "chrome/browser/ui/browser_command_controller.h"
95 #include "chrome/browser/ui/browser_commands.h" 95 #include "chrome/browser/ui/browser_commands.h"
96 #include "chrome/browser/ui/browser_content_setting_bubble_model_delegate.h" 96 #include "chrome/browser/ui/browser_content_setting_bubble_model_delegate.h"
97 #include "chrome/browser/ui/browser_content_translate_driver_observer.h"
97 #include "chrome/browser/ui/browser_dialogs.h" 98 #include "chrome/browser/ui/browser_dialogs.h"
98 #include "chrome/browser/ui/browser_finder.h" 99 #include "chrome/browser/ui/browser_finder.h"
99 #include "chrome/browser/ui/browser_instant_controller.h" 100 #include "chrome/browser/ui/browser_instant_controller.h"
100 #include "chrome/browser/ui/browser_iterator.h" 101 #include "chrome/browser/ui/browser_iterator.h"
101 #include "chrome/browser/ui/browser_language_state_observer.h"
102 #include "chrome/browser/ui/browser_list.h" 102 #include "chrome/browser/ui/browser_list.h"
103 #include "chrome/browser/ui/browser_navigator.h" 103 #include "chrome/browser/ui/browser_navigator.h"
104 #include "chrome/browser/ui/browser_tab_contents.h" 104 #include "chrome/browser/ui/browser_tab_contents.h"
105 #include "chrome/browser/ui/browser_tab_restore_service_delegate.h" 105 #include "chrome/browser/ui/browser_tab_restore_service_delegate.h"
106 #include "chrome/browser/ui/browser_tab_strip_model_delegate.h" 106 #include "chrome/browser/ui/browser_tab_strip_model_delegate.h"
107 #include "chrome/browser/ui/browser_tabstrip.h" 107 #include "chrome/browser/ui/browser_tabstrip.h"
108 #include "chrome/browser/ui/browser_toolbar_model_delegate.h" 108 #include "chrome/browser/ui/browser_toolbar_model_delegate.h"
109 #include "chrome/browser/ui/browser_ui_prefs.h" 109 #include "chrome/browser/ui/browser_ui_prefs.h"
110 #include "chrome/browser/ui/browser_window.h" 110 #include "chrome/browser/ui/browser_window.h"
111 #include "chrome/browser/ui/chrome_pages.h" 111 #include "chrome/browser/ui/chrome_pages.h"
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
343 new BrowserContentSettingBubbleModelDelegate(this)), 343 new BrowserContentSettingBubbleModelDelegate(this)),
344 toolbar_model_delegate_(new BrowserToolbarModelDelegate(this)), 344 toolbar_model_delegate_(new BrowserToolbarModelDelegate(this)),
345 tab_restore_service_delegate_(new BrowserTabRestoreServiceDelegate(this)), 345 tab_restore_service_delegate_(new BrowserTabRestoreServiceDelegate(this)),
346 synced_window_delegate_(new BrowserSyncedWindowDelegate(this)), 346 synced_window_delegate_(new BrowserSyncedWindowDelegate(this)),
347 bookmark_bar_state_(BookmarkBar::HIDDEN), 347 bookmark_bar_state_(BookmarkBar::HIDDEN),
348 command_controller_(new chrome::BrowserCommandController( 348 command_controller_(new chrome::BrowserCommandController(
349 this, g_browser_process->profile_manager())), 349 this, g_browser_process->profile_manager())),
350 window_has_shown_(false), 350 window_has_shown_(false),
351 chrome_updater_factory_(this), 351 chrome_updater_factory_(this),
352 weak_factory_(this), 352 weak_factory_(this),
353 language_state_observer_(new BrowserLanguageStateObserver(this)) { 353 translate_driver_observer_(
354 new BrowserContentTranslateDriverObserver(this)) {
354 // If this causes a crash then a window is being opened using a profile type 355 // If this causes a crash then a window is being opened using a profile type
355 // that is disallowed by policy. The crash prevents the disabled window type 356 // that is disallowed by policy. The crash prevents the disabled window type
356 // from opening at all, but the path that triggered it should be fixed. 357 // from opening at all, but the path that triggered it should be fixed.
357 CHECK(IncognitoModePrefs::CanOpenBrowser(profile_)); 358 CHECK(IncognitoModePrefs::CanOpenBrowser(profile_));
358 CHECK(!profile_->IsGuestSession() || profile_->IsOffTheRecord()) 359 CHECK(!profile_->IsGuestSession() || profile_->IsOffTheRecord())
359 << "Only off the record browser may be opened in guest mode"; 360 << "Only off the record browser may be opened in guest mode";
360 361
361 // TODO(jeremy): Move to initializer list once flag is removed. 362 // TODO(jeremy): Move to initializer list once flag is removed.
362 if (IsFastTabUnloadEnabled()) 363 if (IsFastTabUnloadEnabled())
363 fast_unload_controller_.reset(new chrome::FastUnloadController(this)); 364 fast_unload_controller_.reset(new chrome::FastUnloadController(this));
(...skipping 1725 matching lines...) Expand 10 before | Expand all | Expand 10 after
2089 2090
2090 // ...and all the helpers. 2091 // ...and all the helpers.
2091 BookmarkTabHelper::FromWebContents(web_contents)->set_delegate(delegate); 2092 BookmarkTabHelper::FromWebContents(web_contents)->set_delegate(delegate);
2092 WebContentsModalDialogManager::FromWebContents(web_contents)-> 2093 WebContentsModalDialogManager::FromWebContents(web_contents)->
2093 SetDelegate(delegate); 2094 SetDelegate(delegate);
2094 CoreTabHelper::FromWebContents(web_contents)->set_delegate(delegate); 2095 CoreTabHelper::FromWebContents(web_contents)->set_delegate(delegate);
2095 SearchEngineTabHelper::FromWebContents(web_contents)->set_delegate(delegate); 2096 SearchEngineTabHelper::FromWebContents(web_contents)->set_delegate(delegate);
2096 ZoomController::FromWebContents(web_contents)->set_observer(delegate); 2097 ZoomController::FromWebContents(web_contents)->set_observer(delegate);
2097 TranslateTabHelper* translate_tab_helper = 2098 TranslateTabHelper* translate_tab_helper =
2098 TranslateTabHelper::FromWebContents(web_contents); 2099 TranslateTabHelper::FromWebContents(web_contents);
2099 translate_tab_helper->language_state().set_observer( 2100 translate_tab_helper->translate_driver().set_observer(
2100 delegate ? delegate->language_state_observer_.get() : NULL); 2101 delegate ? delegate->translate_driver_observer_.get() : NULL);
2101 } 2102 }
2102 2103
2103 void Browser::CloseFrame() { 2104 void Browser::CloseFrame() {
2104 window_->Close(); 2105 window_->Close();
2105 } 2106 }
2106 2107
2107 void Browser::TabDetachedAtImpl(content::WebContents* contents, 2108 void Browser::TabDetachedAtImpl(content::WebContents* contents,
2108 int index, 2109 int index,
2109 DetachType type) { 2110 DetachType type) {
2110 if (type == DETACH_TYPE_DETACH) { 2111 if (type == DETACH_TYPE_DETACH) {
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
2292 if (contents && !allow_js_access) { 2293 if (contents && !allow_js_access) {
2293 contents->web_contents()->GetController().LoadURL( 2294 contents->web_contents()->GetController().LoadURL(
2294 target_url, 2295 target_url,
2295 content::Referrer(), 2296 content::Referrer(),
2296 content::PAGE_TRANSITION_LINK, 2297 content::PAGE_TRANSITION_LINK,
2297 std::string()); // No extra headers. 2298 std::string()); // No extra headers.
2298 } 2299 }
2299 2300
2300 return contents != NULL; 2301 return contents != NULL;
2301 } 2302 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/browser_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698