Issue 133273026: cc: Remove ReadPixels from compositor layer_unittests.cc

Issue 133273026: cc: Remove ReadPixels from compositor layer_unittests.cc (Closed)

Created:
6 years, 11 months ago by enne (OOO)

Modified:
6 years, 10 months ago

Reviewers:
danakj

CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cc: Remove ReadPixels from compositor layer_unittests.cc BUG=332167 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245601 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248068

Patch Set 2 : Chunk mismatch #

Patch Set 4 : Remove unused task runner #

Total comments: 3

Patch Set 5 : Simplify result #

Patch Set 8 : Test patch 2: more logging, schedule draw #

Patch Set 10 : Final patch #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -3 lines)			Patch
	M	ui/compositor/layer_unittest.cc	View	1 2 3 4 5 6 7 8 9	4 chunks	+54 lines, -3 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

danakj

LGTM https://codereview.chromium.org/133273026/diff/120001/ui/compositor/layer_unittest.cc File ui/compositor/layer_unittest.cc (right): https://codereview.chromium.org/133273026/diff/120001/ui/compositor/layer_unittest.cc#newcode187 ui/compositor/layer_unittest.cc:187: const SkBitmap& result() const { return *result_.get(); } ...

6 years, 11 months ago (2014-01-17 17:36:36 UTC) #2

enne (OOO)

https://codereview.chromium.org/133273026/diff/120001/ui/compositor/layer_unittest.cc File ui/compositor/layer_unittest.cc (right): https://codereview.chromium.org/133273026/diff/120001/ui/compositor/layer_unittest.cc#newcode187 ui/compositor/layer_unittest.cc:187: const SkBitmap& result() const { return *result_.get(); } On ...

6 years, 11 months ago (2014-01-17 17:51:13 UTC) #3

enne (OOO)

6 years, 11 months ago (2014-01-17 17:52:26 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/133273026/260001

6 years, 11 months ago (2014-01-17 17:53:07 UTC) #5

enne (OOO)

Reopening because this got reverted in https://src.chromium.org/viewvc/chrome?revision=245673&view=revision No new patch yet.

6 years, 11 months ago (2014-01-21 17:57:07 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/133273026/590001

6 years, 10 months ago (2014-01-30 21:16:08 UTC) #9

commit-bot: I haz the power

6 years, 10 months ago (2014-01-30 23:16:09 UTC) #11

Message was sent while issue was closed.

CQ bit was unchecked on CL. Ignoring.

Expand Messages | Collapse Messages