Source/web/PopupListBox.cpp - Issue 133273021: Use isSpaceOrNewline rather than its implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/PopupListBox.cpp

Issue 133273021: Use isSpaceOrNewline rather than its implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Oops, logic error... Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/PopupListBox.cpp

diff --git a/Source/web/PopupListBox.cpp b/Source/web/PopupListBox.cpp

index daa7e9b82f93f3ef5963970fa5a74009772d0222..bc7fb83b58f5d2228eb048c56c550b6005f42f91 100644

--- a/Source/web/PopupListBox.cpp

+++ b/Source/web/PopupListBox.cpp

@@ -288,7 +288,7 @@ static String stripLeadingWhiteSpace(const String& string)

int i;

for (i = 0; i < length; ++i)

if (string[i] != noBreakSpace

- && (string[i] <= 0x7F ? !isASCIISpace(string[i]) : (direction(string[i]) != WhiteSpaceNeutral)))

+ && !isSpaceOrNewline(string[i]))

break;

return string.substring(i, length - i);

« no previous file with comments | « Source/core/html/forms/TypeAhead.cpp ('k') | no next file » | no next file with comments »