Issue 133273021: Use isSpaceOrNewline rather than its implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 133273021: Use isSpaceOrNewline rather than its implementation (Closed)

Created:
6 years, 11 months ago by rwlbuis

Modified:
6 years, 11 months ago

Reviewers:
Stephen Chennney, abarth-chromium, aklein

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Use isSpaceOrNewline rather than its implementation These two if statements use the isSpaceOrNewline implementation but it is clearer and safer to call the inlined method instead. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165283

Patch Set 1 #

Patch Set 2 : Oops, logic error... #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/core/html/forms/TypeAhead.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/web/PopupListBox.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/133273021/30001

6 years, 11 months ago (2014-01-17 06:52:36 UTC) #3

Message was sent while issue was closed.

Change committed as 165283

Expand Messages | Collapse Messages