Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 133273020: Relanding this as this caused layout tests failures on Win7 due to the call to ShowScrollBars being… (Closed)

Created:
6 years, 11 months ago by ananta
Modified:
6 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Relanding this as this caused layout tests failures on Win7 due to the call to ShowScrollBars being incorrectly deleted in the HWNDMessageHandler::OnSize for a regular WM_SIZE. Added that call back. The rest of the CL is exactly the same as the previous one. TBR'ing sky. Don't set the scroll styles (WS_VSCROLL and WS_HSCROLL) for WS_POPUP windows. This causes issues with select boxes on Windows 7 where hovering at the end of the window returns the scroll WM_NCHITTEST codes. Works fine on Windows 8. In any case we don't want the scrolling styles set on windows other than the main Chrome window which is the only window which should be receive mousewheel messages. I moved the scroll style setting code from the HWNDMessageHandler::OnCreate function to HWNDMessageHandler::Init function as that would prevent the initial WM_SIZE message from hiding the scrollbar. The other change is to hide the scrollbars and readd the scroll styles if we are sizing the window, when the sizing completes. Basically when we receive the WM_EXITSIZEMOVE message. For normal sizing operations we continue to do this in WM_SIZE as before. From testing on my thinkpad with Win7, desktop with Win7 and Win8 this works well BUG=334454, 334541 TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -29 lines) Patch
M ui/views/win/hwnd_message_handler.h View 1 chunk +5 lines, -2 lines 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 6 chunks +47 lines, -27 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
6 years, 11 months ago (2014-01-16 11:26:30 UTC) #1
ananta
6 years, 11 months ago (2014-01-16 19:45:17 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r245289 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698